Description of problem: When creating an independent/cloned VM from a template. You cannot set the backup_mode to incremental on creation. Its only possible to set it after creation. How reproducible: Always Steps to Reproduce: 1. Create a VM from a Template 2. On the disk_attachment set disk.backup = virtsdk4.types.DiskBackup.INCREMENTAL Actual results: The VM gets created, but its not having incremental mode enabled on the disk Additional info: My guess is that the root cause is in the following code: https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java#L121 Here you see only some parameters are copied/used, the rest is just ignored. I think we should add all relevant parameters here?
The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.
Nir, is there any reason not allow this setting or do this differently?
I think we decided not to persist the backup mode in templates, since it is not clear that when creating new vm from template you should magically get backup=incremental from the template. But when creating a vm from template using the API, when a user specify backup=incremental, we must respect this value. If we don't respect it, there is no way to create a new vm using qcow2 preallocated on block storage, or thin qcow2 on file storage (would become raw-sparse).
*** Bug 2081554 has been marked as a duplicate of this bug. ***
QE is on a really tight schedule in 4.5.1 with many other bugs to verify, CNACK on capacity from QE side. As this bug changed severity to high at the last moment(yesterday) and the verification deadline is this week this will be on best effort.
Closed based on DEV verification for the fix
This bugzilla is included in oVirt 4.5.1 release, published on June 22nd 2022. Since the problem described in this bug report should be resolved in oVirt 4.5.1 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.