Bug 2048007 - Review Request: rust-glyph_brush_layout - Text layout for ab_glyph
Summary: Review Request: rust-glyph_brush_layout - Text layout for ab_glyph
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1978432
TreeView+ depends on / blocked
 
Reported: 2022-01-29 03:13 UTC by Rémi Lauzier
Modified: 2022-02-14 01:35 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-02-05 04:01:50 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Comment 1 Michel Lind 2022-02-03 22:57:29 UTC
if you need the fonts for tests you can probably just list them as additional sources, then check them into the lookaside cache with 'fedpkg new-sources'. That opens another can of worms though - what licenses are the fonts under? I don't see any license declaration for them. So probably best to leave them off for now.

You might want to consider selectively marking the tests that need fonts as #[ignore], that way the rest can run. But either way, not a blocker.

=== 

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- ! test suite is run and all unit tests pass => explanation provided
- latest version of the crate is packaged
- license matches upstream specification (ASL 2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add package to rust-sig with "commit" access

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Gwyn Ciesla 2022-02-04 14:23:39 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-glyph_brush_layout

Comment 3 Fedora Update System 2022-02-05 04:01:26 UTC
FEDORA-2022-9c91cc4197 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9c91cc4197

Comment 4 Fedora Update System 2022-02-05 04:01:50 UTC
FEDORA-2022-9c91cc4197 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Fedora Update System 2022-02-05 04:16:08 UTC
FEDORA-2022-4e2703d0dc has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4e2703d0dc

Comment 6 Fedora Update System 2022-02-05 04:33:36 UTC
FEDORA-2022-8cdfa851ca has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8cdfa851ca

Comment 7 Fedora Update System 2022-02-06 01:56:13 UTC
FEDORA-2022-4e2703d0dc has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4e2703d0dc \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4e2703d0dc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-02-06 03:02:15 UTC
FEDORA-2022-8cdfa851ca has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-8cdfa851ca \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8cdfa851ca

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-02-14 01:00:11 UTC
FEDORA-2022-8cdfa851ca has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2022-02-14 01:35:16 UTC
FEDORA-2022-4e2703d0dc has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.