Bug 2048362 - Forge macros do not follow the versioning policy for snapshots
Summary: Forge macros do not follow the versioning policy for snapshots
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: forge-srpm-macros
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Maxwell G
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-31 04:43 UTC by Davide Cavalca
Modified: 2023-09-10 00:32 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-10 00:32:12 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Davide Cavalca 2022-01-31 04:43:21 UTC
While reviewing https://bugzilla.redhat.com/show_bug.cgi?id=2044700 salimma noticed that the Forge macros are producing NVRs that aren't in line with the policy at https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots (specifically, the policy leverages the caret/tilde operators and puts the snapshot in the version, not the release).

Comment 1 Ben Cotton 2022-02-08 20:24:43 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 2 Michael J Gruber 2022-03-01 12:08:08 UTC
(In reply to Davide Cavalca from comment #0)
> While reviewing https://bugzilla.redhat.com/show_bug.cgi?id=2044700 salimma
> noticed that the Forge macros are producing NVRs that aren't in line with
> the policy at
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
> #_snapshots (specifically, the policy leverages the caret/tilde operators
> and puts the snapshot in the version, not the release).

You reference the new licensing scheme here.

Have you checked whether the forge macros follow the traditional versionning scheme which is mentioned there, too? It still "may be used" according to the guidelines, and it is in use at least for some packages.

So, I assume this is more of an RFE to update the forge macros to the new scheme?

Comment 3 Sergey 2022-10-06 17:18:24 UTC
Hi,

I just filed the PR [0] that implements '%forgeversion' macro to use in a `Version:` tag instead of actual version.
It has some limitations, of course:

- `%version` has to be defined before `%forgemeta`;
- `%forgemeta` has to precede `Version`, obviously;
- it does nothing with ~.pre/~.rc, as it is almost impossible to make any heuristics on how people mark prereleases;

But it does one usially annoying thing: it allows inclusion of snapshot id into version number with ease.

Unless the new switch `-n` is used with `%forgemeta` its behavior remains unchanged.
 
[0] https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/223 

Thank you,
Sergey

Comment 4 Ben Cotton 2023-04-25 16:52:34 UTC
This message is a reminder that Fedora Linux 36 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 36 on 2023-05-16.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '36'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 36 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 5 Fedora Release Engineering 2023-08-16 07:05:13 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.

Comment 6 Maxwell G 2023-09-10 00:32:12 UTC
As part of https://fedoraproject.org/wiki/Changes/Revitalize_Forge_Macros, the forge macros were moved out of redhat-rpm-config and into a new forge-srpm-macros project. The new package has implemented %forgeversion functionality in a different, more robust way. Thanks Davide and Sergey for getting this started.


Note You need to log in before you can comment on or make changes to this bug.