Spec URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth.spec SRPM URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-1.fc35.src.rpm Description: C99 library implementation of AWS client-side authentication: standard credentials providers and signing. Fedora Account System Username: davdunc
SRPM URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-2.fc35.src.rpm
Taking this review.
> %files > %license LICENSE > %doc README.md > > %files libs > %{_libdir}/libaws-c-auth.so > %{_libdir}/libaws-c-auth.so.1.0.0 These two files sections can be collapsed into a single "%files libs" section. And "%{_libdir}/libaws-c-auth.so" needs to be in the devel subpackage. Finally, with these changes, the libs subpackage shouldn't depend on an empty main package that isn't going to be made, so: > Requires: %{name}%{?_isa} = %{version}-%{release} should be dropped.
> %{_libdir}/aws-c-auth/cmake/aws-c-auth-config.cmake > %{_libdir}/aws-c-auth/cmake/shared/aws-c-auth-targets-noconfig.cmake > %{_libdir}/aws-c-auth/cmake/shared/aws-c-auth-targets.cmake The directory structure is wrong here. This needs to be "%{_libdir}/cmake/aws-c-auth" instead of "%{_libdir}/aws-c-auth/cmake". The CMake dependency generator isn't picking up anything and CMake can't use the modules unless it's in the right directory structure.
Updated for all of these issues. Bumped spec SPEC: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth.spec SRPM: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-3.fc35.src.rpm
SRPM URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth-0.6.5-6.fc35.src.rpm Spec URL: https://davdunc.fedorapeople.org/awscli-2-rpms/aws-c-auth.spec
This can't proceed until its build dependencies are cleared.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
*** This bug has been marked as a duplicate of bug 2279012 ***