RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2049414 - [RFE] Filesystem: Support for mounting by label
Summary: [RFE] Filesystem: Support for mounting by label
Keywords:
Status: CLOSED ERRATA
Alias: None
Deadline: 2022-04-25
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: resource-agents
Version: 8.5
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: 8.7
Assignee: Oyvind Albrigtsen
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks: 2072371
TreeView+ depends on / blocked
 
Reported: 2022-02-02 07:59 UTC by Reid Wahl
Modified: 2022-11-08 09:11 UTC (History)
7 users (show)

Fixed In Version: resource-agents-4.9.0-19.el8
Doc Type: Enhancement
Doc Text:
Clone Of:
: 2072371 (view as bug list)
Environment:
Last Closed: 2022-11-08 09:09:06 UTC
Type: Feature Request
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-110660 0 None None None 2022-02-02 08:13:02 UTC
Red Hat Knowledge Base (Solution) 6774831 0 None None None 2022-03-02 18:31:58 UTC
Red Hat Product Errata RHBA-2022:7443 0 None None None 2022-11-08 09:09:47 UTC

Description Reid Wahl 2022-02-02 07:59:09 UTC
Description of problem:

Currently, mounting a filesystem by the device's label fails if there's a space between "-L" and the label. For example, `device="-L IPXE"`. This is because we double-quote the DEVICE variable, which prevents word splitting, when we use it in the mount command.

We can't remove the double quoting, because it was the fix for BZ 1624591, which enabled us to mount devices that **actually** have whitespace in their names.

So I think we have two options:

1. Add a flag (e.g., `uselabel=true`, with default value set to false) that tells the Filesystem resource agent to treat the `device` option as a device label instead of a device name. Then use `$MOUNT -L "$DEVICE"` instead of `$MOUNT "$DEVICE"` if uselabel=true. I favor this option.
2. Do nothing and simply instruct users to omit the space after the -L. So in our example, it would be `device="-LIPXE"` instead of `device="-L IPXE"`. I think this will work but it's a bit counterintuitive and harder to read.

-----

Version-Release number of selected component (if applicable):

resource-agents-4.1.1-98.el8

-----

How reproducible:

Always

-----

Steps to Reproduce:
1. Configure a Filesystem resource with a label in the device attribute (e.g., `device="-L mylabel"`).
2. Try to start the resource.

-----

Actual results:

ERROR: Couldn't mount device [-L mylabel] as /mnt/my_fs'

-----

Expected results:

Resource starts and filesystem mounts.

Comment 3 Oyvind Albrigtsen 2022-04-01 07:35:37 UTC
https://github.com/ClusterLabs/resource-agents/pull/1757

Comment 4 Oyvind Albrigtsen 2022-04-21 08:33:22 UTC
Additional patch to improve the logic: https://github.com/ClusterLabs/resource-agents/pull/1763

Comment 12 errata-xmlrpc 2022-11-08 09:09:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (resource-agents bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:7443


Note You need to log in before you can comment on or make changes to this bug.