Bug 2049626 - python-asyncio-dgram fails to build with Python 3.11: TypeError: socket type must be SOCK_DGRAM
Summary: python-asyncio-dgram fails to build with Python 3.11: TypeError: socket type ...
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: python-asyncio-dgram
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabian Affolter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2098825 (view as bug list)
Depends On:
Blocks: F38FTBFS PYTHON3.11 F37FTBFS F37FailsToInstall
TreeView+ depends on / blocked
 
Reported: 2022-02-02 13:30 UTC by Tomáš Hrnčiar
Modified: 2022-08-17 11:54 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-17 11:53:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2022-02-02 13:30:56 UTC
python-asyncio-dgram fails to build with Python 3.11.0a4.

=================================== FAILURES ===================================
_________________________ test_from_socket_bad_socket __________________________

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7fc86ee41a10>

    @pytest.mark.asyncio
    async def test_from_socket_bad_socket(monkeypatch):
        class MockSocket:
            family = socket.AF_PACKET
    
        with monkeypatch.context() as m:
            m.setattr(socket, "socket", lambda _, __: MockSocket())
            sock = socket.socket(socket.AF_UNIX, socket.SOCK_DGRAM)
            with pytest.raises(TypeError, match="socket family not one of"):
                await asyncio_dgram.from_socket(sock)
    
        with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as sock:
            with pytest.raises(TypeError, match="must be SocketKind.SOCK_DGRAM"):
>               await asyncio_dgram.from_socket(sock)

test/test_aio.py:251: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

sock = <socket.socket [closed] fd=-1, family=AF_INET, type=SOCK_STREAM, proto=0>

    async def from_socket(sock):
        """
        Create a DatagramStream from a socket.  This is meant to be used in cases
        where the defaults set by `bind()` and `connect()` are not desired and/or
        sufficient.  If `socket.connect()` was previously called on the socket,
        then an instance of DatagramClient will be returned, otherwise an instance
        of DatagramServer.
    
        @param sock - socket to use in the DatagramStream.
        @return     - A DatagramClient for connected sockets, otherwise a
                      DatagramServer.
        """
        loop = asyncio.get_event_loop()
        recvq = asyncio.Queue()
        excq = asyncio.Queue()
        drained = asyncio.Event()
    
        supported_families = tuple((socket.AF_INET, socket.AF_INET6, socket.AF_UNIX))
    
        if sock.family not in supported_families:
            raise TypeError(
                "socket family not one of %s"
                % (", ".join(str(f) for f in supported_families))
            )
    
        if sock.type != socket.SOCK_DGRAM:
>           raise TypeError("socket type must be %s" % (socket.SOCK_DGRAM,))
E           TypeError: socket type must be SOCK_DGRAM

../../BUILDROOT/python-asyncio-dgram-1.1.1-5.fc36.x86_64/usr/lib/python3.11/site-packages/asyncio_dgram/aio.py:282: TypeError

During handling of the above exception, another exception occurred:

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7fc86ee41a10>

    @pytest.mark.asyncio
    async def test_from_socket_bad_socket(monkeypatch):
        class MockSocket:
            family = socket.AF_PACKET
    
        with monkeypatch.context() as m:
            m.setattr(socket, "socket", lambda _, __: MockSocket())
            sock = socket.socket(socket.AF_UNIX, socket.SOCK_DGRAM)
            with pytest.raises(TypeError, match="socket family not one of"):
                await asyncio_dgram.from_socket(sock)
    
        with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as sock:
>           with pytest.raises(TypeError, match="must be SocketKind.SOCK_DGRAM"):
E           AssertionError: Regex pattern 'must be SocketKind.SOCK_DGRAM' does not match 'socket type must be SOCK_DGRAM'.

test/test_aio.py:250: AssertionError
=========================== short test summary info ============================
FAILED test/test_aio.py::test_from_socket_bad_socket - AssertionError: Regex ...
================== 1 failed, 18 passed, 1 deselected in 0.83s ==================

https://docs.python.org/3.11/whatsnew/3.11.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.11/fedora-rawhide-x86_64/03270046-python-asyncio-dgram/

For all our attempts to build python-asyncio-dgram with Python 3.11, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/python-asyncio-dgram/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.11:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/

Let us know here if you have any questions.

Python 3.11 is planned to be included in Fedora 37. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.11.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2022-02-08 20:20:39 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 2 Miro Hrončok 2022-06-20 10:16:58 UTC
*** Bug 2098825 has been marked as a duplicate of this bug. ***

Comment 3 Miro Hrončok 2022-06-27 14:53:13 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 4 Miro Hrončok 2022-07-18 22:26:11 UTC
Hello,

This is the second reminder (step 4 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 5 Miro Hrončok 2022-08-17 11:51:33 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok).

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 38.

Thanks for taking care of it!

Comment 6 Miro Hrončok 2022-08-17 11:53:21 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok).

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 37.

Thanks for taking care of it!


Note You need to log in before you can comment on or make changes to this bug.