Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2050420

Summary:	[4.10] Logger object in LSO does not log source location accurately
Product:	OpenShift Container Platform	Reporter:	Jonathan Dobson <jdobson>
Component:	Storage	Assignee:	Jonathan Dobson <jdobson>
Storage sub component:	Local Storage Operator	QA Contact:	Wei Duan <wduan>
Status:	CLOSED DUPLICATE	Docs Contact:
Severity:	medium
Priority:	medium	CC:	aos-bugs, chaoyang, hekumar, jsafrane
Version:	4.10
Target Milestone:	---
Target Release:	4.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	2019532	Environment:
Last Closed:	2022-02-04 20:47:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2019532, 2050883
Bug Blocks:

Description Jonathan Dobson 2022-02-03 22:32:12 UTC

+++ This bug was initially created as a clone of Bug #2019532 +++

Logger object in LSO does not log source location accurately

--- Additional comment from Hemant Kumar on 2021-11-02 18:48:55 UTC ---

I think that *sometimes* the logger object does not log source information accurately. For example, I tried adding a logging statement in https://github.com/openshift/local-storage-operator/blob/master/diskmaker/controllers/lv/reconcile.go#L219 and it logged:

2021-11-02T18:33:16.207Z        INFO    diskmaker-controllers.Deleter   controller/controller.go:298    Looking for released PVs to clean up    {"Request.Namespace": "openshift-local-storage", "Request.Name": ""}                                                                                                                                                                                                                    2021-11-02T18:33:16.207Z        INFO    diskmaker-controllers.LocalVolume       controller/controller.go:298    ignoring pv     {"request.namespace": "openshift-local-storage", "Request.Name": "local-disks", "pvname": "pv0018", "prov-by": "", "runtime-name": "local-volume-provisioner-crc-dzk9v-master-0-febf7407-d1ed-4a8a-a94b-77724408b477"}                                                                                  2021-11-02T18:33:16.207Z        INFO    diskmaker-controllers.LocalVolume       controller/controller.go:298    ignoring pv     {"request.namespace": "openshift-local-storage", "Request.Name": "local-disks", "pvname": "pv0007", "prov-by": "", "runtime-name": "local-volume-provisioner-crc-dzk9v-master-0-febf7407-d1ed-4a8a-a94b-77724408b477"}                                                                                  I1102 18:33:16.207685 2670386 cache.go:55] Added pv "local-pv-77682331" to cache                                                                                                                                                                                                                                                                                                                                                        2021-11-02T18:33:16.207Z        INFO    diskmaker-controllers.LocalVolume       controller/controller.go:298    ignoring pv     {"request.namespace": "openshift-local-storage", "Request.Name": "local-disks", "pvname": "pv0024", "prov-by": "", "runtime-name": "local-volume-provisioner-crc-dzk9v-master-0-febf7407-d1ed-4a8a-a94b-77724408b477"}                                                                                  2021-11-02T18:33:16.207Z        INFO    diskmaker-controllers.LocalVolume       controller/controller.go:298    ignoring pv     {"request.namespace": "openshift-local-storage", "Request.Name": "local-disks", "pvname": "pv0030", "prov-by": "", "runtime-name": "local-volume-provisioner-crc-dzk9v-master-0-febf7407-d1ed-4a8a-a94b-77724408b477"}                                                                                  2021-11-02T18:33:16.207Z        INFO    diskmaker-controllers.LocalVolume       controller/controller.go:298    ignoring pv     {"request.namespace": "openshift-local-storage", "Request.Name": "local-disks", "pvname": "pv0029", "prov-by": "", "runtime-name": "local-volume-provisioner-crc-dzk9v-master-0-febf7407-d1ed-4a8a-a94b-77724408b477"}                                                                                  2021-11-02T18:33:16.207Z        INFO    diskmaker-controllers.LocalVolume       controller/controller.go:298    ignoring pv     {"request.namespace": "openshift-local-storage", "Request.Name": "local-disks", "pvname": "pv0006", "prov-by": "", "runtime-name": "local-volume-provisioner-crc-dzk9v-master-0-febf7407-d1ed-4a8a-a94b-77724408b477"}                                                                                  2021-11-02T18:33:16.207Z        INFO    diskmaker-controllers.LocalVolume       controller/controller.go:298    ignoring pv     {"request.namespace": "openshift-local-storage", "Request.Name": "local-disks", "pvname": "pv0021", "prov-by": "", "runtime-name": "local-volume-provisioner-crc-dzk9v-master-0-febf7407-d1ed-4a8a-a94b-77724408b477"}                                                                                  2021-11-02T18:33:16.207Z        INFO    diskmaker-controllers.LocalVolume       controller/controller.go:298    ignoring pv     {"request.namespace": "openshift-local-storage", "Request.Name": "local-disks", "pvname": "pv0020", "prov-by": "", "runtime-name": "local-volume-provisioner-crc-dzk9v-master-0-febf7407-d1ed-4a8a-a94b-77724408b477"}                                                                                  2021-11-02T18:33:16.207Z        INFO    diskmaker-controllers.LocalVolume       controller/controller.go:298    ignoring pv     {"request.namespace": "openshift-local-storage", "Request.Name": "local-disks", "pvname": "pv0009", "prov-by": "", "runtime-name": "local-volume-provisioner-crc-dzk9v-master-0-febf7407-d1ed-4a8a-a94b-77724408b477"}                                                                                  

Which seems strange to me. This will perhaps require investigation. Overall, I wonder if we should just move back to klog everywhere since that is what all OCP projects use.

Comment 1 Jonathan Dobson 2022-02-04 20:47:50 UTC


*** This bug has been marked as a duplicate of bug 2050883 ***