Bug 205043 - Review Request: geda-gattrib - Attribute editor for gEDA
Summary: Review Request: geda-gattrib - Attribute editor for gEDA
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Keywords:
: 177413 (view as bug list)
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-09-02 22:04 UTC by Chitlesh GOORAH
Modified: 2008-12-25 11:32 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2006-09-06 09:46:39 UTC
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chitlesh GOORAH 2006-09-02 22:04:56 UTC
Spec URL: http://chitlesh.funpic.de/rpm/geda-gattrib.spec
SRPM URL: http://chitlesh.funpic.de/rpm/geda-gattrib-20060123-3.src.rpm
Description:
Gattrib is gEDA's attribute editor. It reads a set of gschem .sch files
(schematic files), and creates a spreadsheet showing all components in
rows, with the associated component attributes listed in the columns.
It allows the user to add, modify, or delete component attributes outside
of gschem, and then save the .sch files back out. When it is completed,
it will allow the user to edit attributes attached to components, nets,
and pins. (Currently, only component attribute editing is implemented;
pin attributes are displayed only, and net attributes are TBD.)

Comment 1 Chitlesh GOORAH 2006-09-02 22:06:51 UTC
*** Bug 177413 has been marked as a duplicate of this bug. ***

Comment 2 Mamoru TASAKA 2006-09-04 07:05:13 UTC
First review of geda-gattrib.

1. From http://fedoraproject.org/wiki/Packaging/Guidelines :

   * BuildRequires:
     - libpng-devel <- required by gd-devel
                    <- required by libgeda-devel

   * Desktop files:
     - No icon is installed in a proper directory.
     fedora-gattrib.desktop says that "gattrib.{png,xpm}" should
     be installed in a proper directory.

2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :

   = Nothing.

3. Other things I have noticed :

   = Nothing.

Comment 4 Mamoru TASAKA 2006-09-04 14:44:46 UTC
Well;

I just wondered why no icon are shown on Gattrib menu and
I found the problem.

Source1 has a typo:

icon=gattrib should be Icon=gattrib .

Just fix it. Then I recheck if a proper icon appears on Gattrib menu.

Comment 5 Chitlesh GOORAH 2006-09-04 21:01:31 UTC
Updated:
Spec URL: http://chitlesh.funpic.de/rpm/geda-gattrib.spec
SRPM URL: http://chitlesh.funpic.de/rpm/geda-gattrib-20060824-1.src.rpm

Example:
gattrib /usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch

Comment 6 Mamoru TASAKA 2006-09-05 07:31:01 UTC
Well...

[tasaka1@dhcp151 geda-gattrib]$ gattrib
/usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch
gEDA/gattrib version 20060824
gEDA/gattrib comes with ABSOLUTELY NO WARRANTY; see COPYING for more details.
This is free software, and you are welcome to redistribute it under certain
conditions; please see the COPYING file for more details.
Loading file [/usr/share/gEDA/examples/RF_Amp]
Couldn't load schematic [/usr/share/gEDA/examples/RF_Amp]
No components found in entire design!
Do you have refdeses on your components?  
Exiting. . . .

What does this mean?

Comment 7 Stuart Brorson 2006-09-05 13:49:43 UTC
I am the author of this program.

  Well...

  [tasaka1@dhcp151 geda-gattrib]$ gattrib
  /usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch
  gEDA/gattrib version 20060824
  gEDA/gattrib comes with ABSOLUTELY NO WARRANTY; see COPYING for more details.
  This is free software, and you are welcome to redistribute it under certain
  conditions; please see the COPYING file for more details.
  Loading file [/usr/share/gEDA/examples/RF_Amp]
  Couldn't load schematic [/usr/share/gEDA/examples/RF_Amp]
  No components found in entire design!
  Do you have refdeses on your components?  
  Exiting. . . .

  What does this mean?

This is the correct behavior.  You tried loading a non-existant file.  The 
path "/usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch" probably doesn't 
exist.  You probably want "/usr/share/gEDA/examples/RF_Amp/MSA-2643.sch" 
(remove one RF_Amp from diretory list).  

In general, gattrib will try to open your .sch file and look for valid 
components.  If it can't find then, it will bail out with the above error 
message.

I agree that the error message might be improved to say "file not found" in 
this case.  I can add that to the list of improvements I intend to do.

Stuart Brorson


Comment 8 Mamoru TASAKA 2006-09-05 14:18:49 UTC
(In reply to comment #7)

> This is the correct behavior.  You tried loading a non-existant file.  The 
> path "/usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch" probably doesn't 
> exist.  You probably want "/usr/share/gEDA/examples/RF_Amp/MSA-2643.sch" 
> (remove one RF_Amp from diretory list).  
> 
> In general, gattrib will try to open your .sch file and look for valid 
> components.  If it can't find then, it will bail out with the above error 
> message.> 
> I agree that the error message might be improved to say "file not found" in 
> this case.  I can add that to the list of improvements I intend to do.
> 
> Stuart Brorson
> 

Hello, Stuart.

Oops... Actually /usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch wasn't
exist... my bad......
Well, I installed geda-examples (I have not accepted geda-examples yet)
and it seems to go right.

Okay, then I recheck this package again. Thank you.


Comment 9 Mamoru TASAKA 2006-09-05 15:05:14 UTC
Okay. No problem.

This package (geda-gattrib) is APPROVED by me.

Comment 10 Chitlesh GOORAH 2008-12-21 19:51:47 UTC
New Package CVS Request
=======================
Package Name: geda-gattrib
Short Description: Attribute editor for gEDA
Owners: chitlesh
Branches: EL-5

Comment 11 Kevin Fenzi 2008-12-23 03:26:22 UTC
cvs done.

Comment 12 Chitlesh GOORAH 2008-12-24 15:33:07 UTC
Sorry Kevin you haven't created the EL-5 branch for geda-gattrib.

Comment 13 Kevin Fenzi 2008-12-25 00:44:55 UTC
Sorry, it was done in pkgdb, but for some reason didn't setup right on cvs. 
Try now? I think I have it fixed.

Comment 14 Chitlesh GOORAH 2008-12-25 11:32:18 UTC
thanks it's fine now.


Note You need to log in before you can comment on or make changes to this bug.