Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2050689

Summary:	[update] validation can break when openstack-tripleo-validation is updated.
Product:	Red Hat OpenStack	Reporter:	Sofer Athlan-Guyot <sathlang>
Component:	python-tripleoclient	Assignee:	OSP Team <rhos-maint>
Status:	CLOSED ERRATA	QA Contact:	Sofer Athlan-Guyot <sathlang>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	16.2 (Train)	CC:	hbrock, jjoyce, jpodivin, jschluet, jslagle, mbultel, mburns, slinaber, tvignaud
Target Milestone:	z3	Keywords:	Triaged
Target Release:	16.2 (Train on RHEL 8.4)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-tripleoclient-12.6.1-2.20220401015648.e47d2ee.el8ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-06-22 16:03:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2037281

Description Sofer Athlan-Guyot 2022-02-04 13:03:11 UTC

Description of problem:

Updating  openstack-tripleo-validation breaks validation as python3-validations-libs.noarch and validations-common.noarch are not updated. This leads to:

2022-02-03 17:15:24.779 | Exception raised: No module named 'validations_libs.cli.community'

when running:

openstack tripleo validator list --group pre-update -f value -c ID

Version-Release number of selected component (if applicable):

Here's what's installed:

openstack-tripleo-validations.noarch          11.6.1-2.20220115004852.c6d8b57.el8ost       @rhelosp-16.2 (from passed_phase2)
python3-validations-libs.noarch               1.1.1-2.20210607091343.04e84c8.el8ost.1      @rhelosp-16.2 (from GA)
validations-common.noarch                     1.1.2-2.20210611010116.el8ost.2              @rhelosp-16.2 (from GA)


How reproducible: always.


Steps to Reproduce:
1. deploy osp16.2 GA
2. run dnf upgrade openstack-tripleo-validations.noarch -y on the undercloud
3. run openstack tripleo validator list --group pre-update -f value -c ID


Actual results:

Exception raised: No module named 'validations_libs.cli.community'

Expected results:

validation are run.

Comment 2 Sofer Athlan-Guyot 2022-02-04 13:19:58 UTC

Moving to validation squad to better understand if that's a package issue and how best solve it, @mbultel can you have a look ?

Comment 4 Sofer Athlan-Guyot 2022-02-04 17:51:52 UTC

there is no min version in the rpm definition:

undercloud) [stack@undercloud-0 ~]$ rpm -qR openstack-tripleo-validations
/bin/bash
/usr/bin/python3
os-net-config >= 7.1.0
python(abi) = 3.6
python3-glanceclient >= 2.9.1
python3-heatclient >= 1.10.0
python3-ironic-inspector-client >= 3.1.1
python3-ironicclient >= 2.3.0
python3-pbr
python3-shade >= 1.24.0
python3dist(ansible) >= 2
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
validations-common

Comment 5 Jon Schlueter 2022-02-04 18:38:46 UTC

if there is a tighter coupling it should be reflected in the requirements.txt underlying as well as the Requires: in the .spec file so that it can be enforced by dnf install /upgrade

Comment 6 Jiri Podivin 2022-02-07 08:30:03 UTC

I do concur that the this is a package issue, although it isn't in the openstack-tripleo-validations package. 
Problem lies in a loose constraint on a dependency between python-tripleoclient and validations-libs. 

Right now the tripleoclient spec file requests >=1.3.0 while the requirements.txt correctly lists >=1.5.0.
We need to bump the constraint in spec file in order for things to work correctly.

Comment 7 mathieu bultel 2022-02-07 08:59:25 UTC

Thank you Sofer for raising this.

I think we just need to fix to the tripleo-validations Requires in the sepcfile.
The 16.2 version of tripleo-validations should not work with lower versions than 1.5.0 for the VF.

Comment 8 Sofer Athlan-Guyot 2022-03-29 12:33:41 UTC

Hi, should we add a kcs to properly update validation or a note in the validation documentation ?

Comment 20 errata-xmlrpc 2022-06-22 16:03:29 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 16.2.3 (Train)), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:4793