RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:

During the build process of stunnel, selftest is executed ('make check') but its result seems to be ignored. Hence build continues even if selftest failed.

Version-Release number of selected component (if applicable):

stunnel-5.62-1.el9

How reproducible:

100%

Steps to Reproduce:

1. Compile the source rpm (rpmbuild -vv -bc).
2. Make selftest fail somehow.
3. Execute the failing self test.

Actual results:

Summary:
   success: 47
   fail: 3
   skipped: 0
File /builddir/build/BUILD/stunnel-5.62/tests/logs/results.log done
Processing files: stunnel-5.62-1.el9.x86_64

Expected results:

Build is aborted.

Additional info:

N/A

The issue is

  %check
  make test || (for i in tests/logs/*.log ; do echo "$i": ; cat "$i" ; done)

which will hide the non-zero exit code of make. I'll fit it.

I manually verified that an error in make test now fails the build by applying this patch:

diff --git a/stunnel.spec b/stunnel.spec
index b2a3fd4..ab6a425 100644
--- a/stunnel.spec
+++ b/stunnel.spec
@@ -100,7 +100,7 @@ cp %{SOURCE7} %{buildroot}%{_unitdir}/%{name}@.service
 %endif

 %check
-if ! make test; then
+if ! ( make test && false ); then
        for i in tests/logs/*.log; do
                echo "$i":
                cat "$i"

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: stunnel), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:4036