Bug 2051372 - Review Request: the_foundation - Opinionated C11 library for low-level functionality
Summary: Review Request: the_foundation - Opinionated C11 library for low-level functi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2051373
TreeView+ depends on / blocked
 
Reported: 2022-02-07 06:38 UTC by Michel Lind
Modified: 2022-02-10 19:39 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-02-10 00:38:02 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-02-07 06:38:59 UTC
Spec URL: https://salimma.fedorapeople.org/specs/web/the_foundation.spec
SRPM URL: https://salimma.fedorapeople.org/specs/web/the_foundation-1.1.0-1.fc35.src.rpm
Description:
An object-oriented C library whose API is designed for a particular coding
style, taking cues from C++ STL and Qt.}

Fedora Account System Username: salimma

Comment 1 Neal Gompa 2022-02-07 14:13:30 UTC
> %{_libdir}/*.so.*

Soversions need to be listed and globbed properly.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files

Also note: https://pagure.io/packaging-committee/pull-request/1162

Comment 2 Michel Lind 2022-02-07 21:53:18 UTC
(In reply to Neal Gompa from comment #1)
> > %{_libdir}/*.so.*
> 
> Soversions need to be listed and globbed properly.
> 
> Cf.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_listing_shared_library_files
> 
> Also note: https://pagure.io/packaging-committee/pull-request/1162

updated, thanks. same URLs.

Going to look into updating the library template for rpmdev-newspec, since this is what tripped me up /even/ after just reading the packaging discussion a couple of days before.

Comment 3 Neal Gompa 2022-02-07 22:11:22 UTC
Review notes:

* Packaging complies with the guidelines
* Package builds and installs
* No serious issues from rpmlint
* Licensing is correct and license files are correctly installed

PACKAGE APPROVED.

Comment 4 Michel Lind 2022-02-07 22:32:55 UTC
Thanks!

~
❯ fedpkg request-repo the_foundation 2051372
https://pagure.io/releng/fedora-scm-requests/issue/41857

~ took 6s
❯ fedpkg request-branch --repo the_foundation --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/41858
https://pagure.io/releng/fedora-scm-requests/issue/41859

~ took 5s
❯ fedpkg request-branch --repo the_foundation epel9
https://pagure.io/releng/fedora-scm-requests/issue/41860

Comment 5 Gwyn Ciesla 2022-02-08 15:13:28 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/the_foundation

Comment 6 Fedora Update System 2022-02-09 00:31:23 UTC
FEDORA-2022-652885bb89 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-652885bb89

Comment 7 Fedora Update System 2022-02-09 00:32:01 UTC
FEDORA-2022-2ef52450a5 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2ef52450a5

Comment 8 Fedora Update System 2022-02-09 00:32:42 UTC
FEDORA-EPEL-2022-419af3b3d4 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-419af3b3d4

Comment 9 Fedora Update System 2022-02-09 00:33:17 UTC
FEDORA-EPEL-2022-a88e3bffde has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-a88e3bffde

Comment 10 Fedora Update System 2022-02-10 00:38:02 UTC
FEDORA-EPEL-2022-a88e3bffde has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-02-10 00:53:05 UTC
FEDORA-EPEL-2022-419af3b3d4 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2022-02-10 01:16:14 UTC
FEDORA-2022-2ef52450a5 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-02-10 01:31:39 UTC
FEDORA-2022-652885bb89 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-02-10 18:47:10 UTC
FEDORA-2022-535004e389 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-535004e389

Comment 15 Fedora Update System 2022-02-10 18:51:11 UTC
FEDORA-2022-535004e389 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-02-10 19:35:37 UTC
FEDORA-2022-d5d803bb28 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d5d803bb28

Comment 17 Fedora Update System 2022-02-10 19:39:13 UTC
FEDORA-2022-d5d803bb28 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.