Bug 2051611 - Remove Check which enforces summary_interval must match logSyncInterval
Summary: Remove Check which enforces summary_interval must match logSyncInterval
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.10
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 4.11.0
Assignee: Joseph Richard
QA Contact: obochan
URL:
Whiteboard:
Depends On:
Blocks: 2055371
TreeView+ depends on / blocked
 
Reported: 2022-02-07 15:43 UTC by Ken Young
Modified: 2022-08-10 10:48 UTC (History)
0 users

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-10 10:47:50 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift ptp-operator pull 174 0 None open Bug 2051611: Remove validating summary_interval matches logSyncInterval 2022-02-14 19:06:04 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 10:48:15 UTC

Description Ken Young 2022-02-07 15:43:49 UTC
Description of problem:
This check although required for events is problematic for our customers.  It creates a volume of logs which is unacceptable.  This bugzilla is requiring the removal of this check.

Version-Release number of selected component (if applicable):
4.11 -> 4.10.

How reproducible:
100%

Steps to Reproduce:
1.  set summary_interval to -4
2.  set logSyncInterval to -4
3.

Actual results:
The volume of the logs is huge given these settings

Expected results:
Have a quiet log that is independent of the frequency

Additional info:

Comment 2 obochan 2022-02-24 19:41:28 UTC
issue is validated  in :
[obochan@obochan scripts]$ oc version
Client Version: 4.8.0
Server Version: 4.10.0-rc.4
Kubernetes Version: v1.23.3+5642c2c

you can see bellow inside the config you have the following:
obochan@obochan scripts]$ oc describe ptpconfigs.ptp.openshift.io worker -n openshift-ptp | grep summary
summary_interval -2
    ptp4lOpts:                -2 -s summary_interval -2

[obochan@obochan scripts]$ oc describe ptpconfigs.ptp.openshift.io worker -n openshift-ptp | grep -i logsync
logSyncInterval -4

[obochan@obochan scripts]$ oc describe ptpconfigs.ptp.openshift.io worker -n openshift-ptp 
Name:         worker
Namespace:    openshift-ptp
Labels:       <none>
Annotations:  <none>
API Version:  ptp.openshift.io/v1
Kind:         PtpConfig
Metadata:
  Creation Timestamp:  2022-02-24T18:53:41Z
  Generation:          1
  Managed Fields:
    API Version:  ptp.openshift.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:profile:
        f:recommend:
    Manager:         kubectl-client-side-apply
    Operation:       Update
    Time:            2022-02-24T18:53:41Z
  Resource Version:  307593
  UID:               2afc1d7e-ff91-4c5b-97bc-b6f0bdaec423
Spec:
  Profile:
    Interface:    ens5f1
    Name:         worker
    phc2sysOpts:  -a -r -n 24 -u 8
    ptp4lConf:    [global]
#
# Default Data Set
#
twoStepFlag 1
slaveOnly 0
priority1 128
priority2 128
domainNumber 24
#utc_offset 37
clockClass 248
clockAccuracy 0xFE
offsetScaledLogVariance 0xFFFF
free_running 0
freq_est_interval 1
dscp_event 0
dscp_general0
dataset_comparison ieee1588
G.8275.defaultDS.localPriority 128
#
# Port Data Set
#
logAnnounceInterval -3
logSyncInterval -4
logMinDelayReqInterval -4
logMinPdelayReqInterval  0
announceReceiptTimeout 3
syncReceiptTimeout 0
delayAsymmetry 0
fault_reset_interval 4
neighborPropDelayThresh  20000000
masterOnly 0
G.8275.portDS.localPriority 128
#
# Run time options
#
assume_two_step 0
logging_level 6
path_trace_enabled 0
follow_up_info 0
hybrid_e2e 0
inhibit_multicast_service 0
net_sync_monitor 0
tc_spanning_tree 0
tx_timestamp_timeout 50
unicast_listen 0
unicast_master_table 0
unicast_req_duration 3600
use_syslog 1
verbose 0
summary_interval -2
kernel_leap 1
check_fup_sync 0
#
# Servo Options
#
pi_proportional_const 0.0
pi_integral_const 0.0
pi_proportional_scale 0.0
pi_proportional_exponent -0.3
pi_proportional_norm_max 0.7
pi_integral_scale 0.0
pi_integral_exponent 0.4
pi_integral_norm_max 0.3
step_threshold 30.0
first_step_threshold 0.00002
max_frequency 900000000
clock_servo pi
#sanity_freq_limit 200000000
ntpshm_segment 0
#
# Transport options
#
transportSpecific 0x0
ptp_dst_mac 01:1B:19:00:00:00
p2p_dst_mac 01:80:C2:00:00:0E
udp_ttl 1
udp6_scope 0x0E
uds_address /var/run/ptp4l
#
# Default interface options
#
clock_type OC
#network_transport UDPv4
network_transport L2
delay_mechanism E2E
time_stamping hardware
tsproc_mode filter
delay_filter moving_median
delay_filter_length  10
egressLatency 0
ingressLatency 0
boundary_clock_jbod  0
#
# Clock description
#
productDescription ;;
revisionData ;;
manufacturerIdentity 00:00:00
userDescription ;
timeSource 0xA0

    ptp4lOpts:                -2 -s summary_interval -2
    Ptp Scheduling Policy:    SCHED_FIFO
    Ptp Scheduling Priority:  65
  Recommend:
    Match:
      Node Label:  node-role.kubernetes.io/master
    Priority:      4
    Profile:       worker
Events:            <none>

Comment 3 obochan 2022-03-09 08:14:05 UTC
issue is validated - via change on the fly via edit and apply configuration 

[obochan@obochan ocp-edge]$ oc version 
Client Version: 4.8.0
Server Version: 4.10.3
Kubernetes Version: v1.23.3+e419edf

[obochan@obochan ocp-edge]$ oc get csv -A | grep ptp
openshift-ptp                                      performance-addon-operator.v4.10.1           Performance Addon Operator                               4.10.1                           Succeeded
openshift-ptp                                      ptp-operator.4.10.0-202203040217             PTP Operator                                             4.10.0-202203040217              Succeeded

obochan@obochan ocp-edge]$ oc describe ptpconfigs.ptp.openshift.io -n openshift-ptp | grep "summa\|log"
logAnnounceInterval -3
logSyncInterval -2
logMinDelayReqInterval -4
logMinPdelayReqInterval -4
logging_level 6
use_syslog 1
summary_interval 0
    ptp4lOpts:  -2 -s --summary_interval -4

Comment 5 errata-xmlrpc 2022-08-10 10:47:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069


Note You need to log in before you can comment on or make changes to this bug.