Bug 2052055 - Whereabouts should implement client-go 1.22+
Summary: Whereabouts should implement client-go 1.22+
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.11
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.11.0
Assignee: Miguel Duarte Barroso
QA Contact: Weibin Liang
Depends On:
Blocks: 2052062
TreeView+ depends on / blocked
Reported: 2022-02-08 15:36 UTC by Douglas Smith
Modified: 2022-08-10 10:48 UTC (History)
0 users

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2052062 (view as bug list)
Last Closed: 2022-08-10 10:47:58 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github openshift whereabouts-cni pull 82 0 None open Bug 2052055: client-go bump to v1.22 2022-02-08 15:58:45 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 10:48:20 UTC

Description Douglas Smith 2022-02-08 15:36:56 UTC
Description of problem: Client-go 1.22+ includes fixes for retries against the API server. While client-go 1.23 is preferable, 1.22 has the fixes we're looking for.

Version-Release number of selected component (if applicable): (all)

How reproducible: The primary problems are reproducible in CI during upgrades, specifically when the SDN is upgrading, this appears in an unacceptable percentage of runs.

Steps to verify: Presence of client-go 1.22 in go.mod & no regressions.

Comment 4 Douglas Smith 2022-02-10 19:18:18 UTC
To verify, you can check if the shipped binary contains the version of the client-go library, for example:

$ oc debug node/ci-ln-1w66kgk-72292-smb8z-worker-a-tbxm5
Starting pod/ci-ln-1w66kgk-72292-smb8z-worker-a-tbxm5-debug ...
To use host binaries, run `chroot /host`
Pod IP:
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host
sh-4.4# cat /var/lib/cni/bin/whereabouts | grep -i "0\.22\.6"
Binary file (standard input) matches

The command `cat /var/lib/cni/bin/whereabouts | grep -i "0\.22\.6"` should produce the output `Binary file (standard input) matches` -- if that is the case, it's verified. If it doesn't match it will have no output, and $? will produce `1` (or another non-zero value)

Comment 5 Weibin Liang 2022-02-10 19:31:06 UTC
Tested and verified in 4.11.0-0.nightly-2022-02-10-031822

[weliang@weliang ~]$ oc debug node/ip-10-0-139-148.us-east-2.compute.internal
Starting pod/ip-10-0-139-148us-east-2computeinternal-debug ...
To use host binaries, run `chroot /host`
Pod IP:
If you don't see a command prompt, try pressing enter.
sh-4.4# chroot /host
sh-4.4# cat /var/lib/cni/bin/whereabouts | grep -i "0\.22\.6"
Binary file (standard input) matches

Comment 7 errata-xmlrpc 2022-08-10 10:47:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.