Bug 2052084 - misleading error: can not set DISTTAG flag
Summary: misleading error: can not set DISTTAG flag
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-review
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-02-08 16:41 UTC by Dr Anirban Mitra
Modified: 2022-12-13 16:36 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-12-13 16:36:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Dr Anirban Mitra 2022-02-08 16:41:54 UTC
Description of problem:
If I set Fedora Review in setting, the frontend shows build failed although build is successful only Fedora Review has failed as there is not option to set --define DISTTAG=fc36 in Fedora review 

Version-Release number of selected component (if applicable):


How reproducible: Every time 


Steps to Reproduce:
1.I select fedora-review as an option in setting 
2.I do a build of my package 
3. After build *.fc36.noarch.rpm and fc36.src.rpm are generated and success files show done 
4. fontend show build failed 

Actual results:
detailed build log shows in end 
"WARNING: No disttag found in prebuilt packages
INFO: Use --define DISTTAG to set proper dist. e. g. --define DISTTAG fc21.
ERROR: 'No disttag in package and no DISTTAG flag. Use --define DISTTAG to set proper dist e. g., --define DISTTAG=fc21."

Expected results:
Expect some option to pass '--define DISTAG ' to fedora review tool 
Frontend should indicate rpm build successful but fedora-review failed 

Additional info: I am new to copr and rpm packaging, so may be I am missing somthing, Manual review by my reviewer passes file.

Comment 1 Miroslav Suchý 2022-02-09 13:40:21 UTC
The error of fedora-review is misleading (changing component to make the error more user-friendly).

The culprit is that you have:

Release:   1

but you should have

Release:   1%{?dist}

Comment 2 Pavel Raiskup 2022-02-09 14:12:49 UTC
> If I set Fedora Review in setting, the frontend shows build failed although build is successful

I think this is tracked here: https://pagure.io/copr/copr/issue/2040
(that said, this is already tracked upstream and we can leave this bug filled against the fedora-review tool)

Comment 3 Dr Anirban Mitra 2022-02-09 14:19:57 UTC
The problem persists even when I set Release 6%{?dist}, for example, in https://copr.fedorainfracloud.org/coprs/mitradranirban/uniol-fonts/build/3330673/

Comment 4 Dr Anirban Mitra 2022-04-11 14:32:06 UTC
(In reply to Pavel Raiskup from comment #2)
> > If I set Fedora Review in setting, the frontend shows build failed although build is successful
> 
> I think this is tracked here: https://pagure.io/copr/copr/issue/2040
> (that said, this is already tracked upstream and we can leave this bug
> filled against the fedora-review tool)

The issue is fixed upstream.

Comment 5 Ben Cotton 2022-11-29 17:51:08 UTC
This message is a reminder that Fedora Linux 35 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '35'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 35 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 6 Ben Cotton 2022-12-13 16:36:39 UTC
Fedora Linux 35 entered end-of-life (EOL) status on 2022-12-13.

Fedora Linux 35 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.