Spec URL: https://download.copr.fedorainfracloud.org/results/alebastr/greetd/fedora-rawhide-x86_64/03005754-rust-enquote/rust-enquote.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/greetd/fedora-rawhide-x86_64/03005754-rust-enquote/rust-enquote-1.1.0-1.fc36.src.rpm Description: Quotes and unquotes strings Fedora Account System Username: alebastr Review notes: rust2rpm -a
Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. Additional note: %autorelease isn't terribly effective if you're putting version-release in manual changelog entries. You probably want to rework your changelog entry to not include the release value (since that would be dynamic) or just switch to %autochangelog. The %autorelease goop at the top of the spec should be dropped on import too.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-enquote
(In reply to Neal Gompa from comment #1) Thanks for the reviews! > Additional note: %autorelease isn't terribly effective if you're putting > version-release in manual changelog entries. You probably want to rework > your changelog entry to not include the release value (since that would be > dynamic) or just switch to %autochangelog. The %autorelease goop at the top > of the spec should be dropped on import too. That's actually added by fedpkg. I forgot that the resulting spec in copr is different from my local copy. I'll make a note to myself to never use copr builds for rpmautospec package reviews.