RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2053100 - nmstate rust removes untouched keys under `ovs-db`
Summary: nmstate rust removes untouched keys under `ovs-db`
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: nmstate
Version: 9.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: 9.2
Assignee: Gris Ge
QA Contact: Mingyu Shi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-02-10 14:31 UTC by Mingyu Shi
Modified: 2023-05-09 08:19 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-09 07:30:59 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github nmstate nmstate pull 2015 0 None Merged ovsdb: Support partial editing on ovs-db global config 2022-09-01 05:10:35 UTC
Red Hat Issue Tracker NMT-523 0 None None None 2023-05-09 00:26:58 UTC
Red Hat Issue Tracker RHELPLAN-111870 0 None None None 2022-02-10 14:38:58 UTC
Red Hat Product Errata RHBA-2023:2190 0 None None None 2023-05-09 07:31:13 UTC

Description Mingyu Shi 2022-02-10 14:31:31 UTC 
Description of problem:
Compared with nmstate python, nmstate rust removes untouched keys under `ovs-db`
when modifying `ovs-db`.

Version-Release number of selected component (if applicable):
nmstate-1.2.1-0.2.alpha2.el8.x86_64
nispor-1.2.3-1.el8.x86_64
NetworkManager-1.36.0-0.7.el8.x86_64
openvswitch2.15-2.15.0-70.el8fdp.x86_64

How reproducible:
100%

Steps to Reproduce:
echo "
ovs-db:
  external_ids:
    hostname: dell-per740-02.rhts.eng.pek2.redhat.com
    rundir: /var/run/openvswitch
    system-id: 590f838a-2515-4fe7-a44d-de1553389bd6
  other_config: {}
" | nmstatectl-rust apply

echo "
ovs-db:
  external_ids: {foo: bar}
  other_config: {UP: DOWN}
" | nmstatectl-rust apply

nmstatectl show # check `ovs-db` key

Actual results:
ovs-db:
  external_ids:
    foo: bar
  other_config:
    UP: DOWN

Expected results:
(If using nmstate python)
ovs-db:
  external_ids:
    foo: bar
    hostname: dell-per740-02.rhts.eng.pek2.redhat.com
    rundir: /var/run/openvswitch
    system-id: 590f838a-2515-4fe7-a44d-de1553389bd6
  other_config:
    UP: DOWN

Additional info:
Comment 1 Gris Ge 2022-07-27 07:57:35 UTC 
Change to RHEL 9 and targeting 9.2
Comment 2 Gris Ge 2022-08-24 09:32:47 UTC 
Patch posted to upstream: https://github.com/nmstate/nmstate/pull/2015

Allowing partial editing on ovs-db global config:
     * Merging desire from current.
     * Will remove all ovs-db global configure for `ovs-db: {}`.
     * To remove single entry, use `foo: null` in yaml.
Comment 3 Mingyu Shi 2022-08-25 02:31:43 UTC 
Pretested
nmstate-2.2.0-0.20220824093819832661.pr2015.11.g225cf980.el9.x86_64
NetworkManager-1.39.90-1.el9.x86_64

The only difference, or improvement, is that the value of `ovs-db.other_config.foo` cannot be integer in the python version, while the rust version can automatically convert integer 1 to string "1" and make it work.
Comment 8 Mingyu Shi 2022-10-24 11:04:23 UTC 
Verified with:
nmstate-2.2.0-0.alpha.20221014.el9.x86_64
NetworkManager-1.40.0-1.el9.x86_64
openvswitch2.15-2.15.0-72.el9fdp.x86_64
Linux dell-per740-79.rhts.eng.pek2.redhat.com 5.14.0-176.el9.x86_64 #1 SMP PREEMPT_DYNAMIC Wed Oct 12 05:23:43 EDT 2022 x86_64 x86_64 x86_64 GNU/Linux
DISTRO=RHEL-9.2.0-20221016.3
Comment 10 errata-xmlrpc 2023-05-09 07:30:59 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2190
Note You need to log in before you can comment on or make changes to this bug.