Spec URL: https://mattia.fedorapeople.org/stellarsolver/stellarsolver.spec SRPM URL: https://mattia.fedorapeople.org/stellarsolver/stellarsolver-1.9-1.20220211git832bc60.fc36.src.rpm Description: StellarSolver is the Cross Platform Sextractor and Internal Astrometric Solver: * An Astrometric Plate Solver for Mac, Linux, and Windows, built on Astrometry.net and SEP (sextractor) * Meant to be an internal library for use in a program like KStars for internal plate solving on all supported operating systems Fedora Account System Username: mattia Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=82691517 This is a second attempt to get stellarsolver packaged, so that we can update kstars. See #1938451 for the old review request.
- I guess MIT should also appear in License: ./stellarsolver/sep/MIT_LICENSE.txt: MIT License ./stellarsolver/astrometry/blind/windirent.h: MIT License - rpmlint complians: stellarsolver.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/StellarSolverTester stellarsolver-libs.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/libstellarsolver.so.1.9 Upstream could be asked to port to getaddrinfo - Nitpick: find %{buildroot} -name '*.la' -exec rm -f {} ';' is usually only needed to autotools, doesn't look necessary here.
(In reply to Sandro Mani from comment #1) > - I guess MIT should also appear in License: > > ./stellarsolver/sep/MIT_LICENSE.txt: MIT License > ./stellarsolver/astrometry/blind/windirent.h: MIT License > Fixed. > - rpmlint complians: > > stellarsolver.x86_64: W: binary-or-shlib-calls-gethostbyname > /usr/bin/StellarSolverTester > stellarsolver-libs.x86_64: W: binary-or-shlib-calls-gethostbyname > /usr/lib64/libstellarsolver.so.1.9 > > Upstream could be asked to port to getaddrinfo > The affected code (/stellarsolver/astrometry/blind/solvedclient.c) has already been removed in the master branch. > - Nitpick: > > find %{buildroot} -name '*.la' -exec rm -f {} ';' > > is usually only needed to autotools, doesn't look necessary here. Fixed. Spec URL: https://mattia.fedorapeople.org/stellarsolver/stellarsolver.spec SRPM URL: https://mattia.fedorapeople.org/stellarsolver/stellarsolver-1.9-2.20220211git832bc60.fc37.src.rpm
You should also add a desktop file for StellarSolverTester: [!]: Package contains desktop file if it is a GUI application. And detail, but I trust this is already solved [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). Diff spec file in url and in SRPM --------------------------------- --- /home/sandro/Desktop/2053682-stellarsolver/srpm/stellarsolver.spec 2022-02-18 23:51:10.413167186 +0100 +++ /home/sandro/Desktop/2053682-stellarsolver/srpm-unpacked/stellarsolver.spec 2022-02-18 23:56:47.780049637 +0100 @@ -90,5 +90,4 @@ %install %cmake_install -find %{buildroot} -name '*.la' -exec rm -f {} ';' Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- stellarsolver.x86_64: W: no-manual-page-for-binary StellarSolverTester stellarsolver-devel.x86_64: W: no-documentation stellarsolver.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/StellarSolverTester stellarsolver-libs.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/libstellarsolver.so.1.9 Source checksums ---------------- https://github.com/rlancaste/stellarsolver/archive/832bc60feb1fc8ffdf2780ccdd413c3baea648fb/stellarsolver-832bc60feb1fc8ffdf2780ccdd413c3baea648fb.tar.gz : CHECKSUM(SHA256) this package : 546e5451a314c34f01c8d70af9f7ee7b32bd47df235a0f5b91887b1b37caac12 CHECKSUM(SHA256) upstream package : 546e5451a314c34f01c8d70af9f7ee7b32bd47df235a0f5b91887b1b37caac12 Requires -------- stellarsolver (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libcfitsio.so.9()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgsl.so.25()(64bit) libgslcblas.so.0()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwcs.so.7()(64bit) rtld(GNU_HASH) stellarsolver-libs(x86-64) stellarsolver-libs (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libcfitsio.so.9()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgsl.so.25()(64bit) libgslcblas.so.0()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwcs.so.7()(64bit) rtld(GNU_HASH) stellarsolver-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) libstellarsolver.so.1()(64bit) stellarsolver-libs(x86-64) stellarsolver-debuginfo (rpmlib, GLIBC filtered): stellarsolver-debugsource (rpmlib, GLIBC filtered): Provides -------- stellarsolver: bundled(astrometry) bundled(sep) stellarsolver stellarsolver(x86-64) stellarsolver-libs: libstellarsolver.so.1()(64bit) stellarsolver-libs stellarsolver-libs(x86-64) stellarsolver-devel: cmake(StellarSolver) cmake(stellarsolver) pkgconfig(stellarsolver) stellarsolver-devel stellarsolver-devel(x86-64) stellarsolver-debuginfo: debuginfo(build-id) stellarsolver-debuginfo stellarsolver-debuginfo(x86-64) stellarsolver-debugsource: stellarsolver-debugsource stellarsolver-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/sandro/Desktop/2053682-stellarsolver/srpm/stellarsolver.spec 2022-02-18 23:51:10.413167186 +0100 +++ /home/sandro/Desktop/2053682-stellarsolver/srpm-unpacked/stellarsolver.spec 2022-02-18 23:56:47.780049637 +0100 @@ -90,5 +90,4 @@ %install %cmake_install -find %{buildroot} -name '*.la' -exec rm -f {} ';' Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2053682 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Ocaml, Python, Haskell, SugarActivity, R, PHP, Ruby, Java, fonts, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Spec URL: https://mattia.fedorapeople.org/stellarsolver/stellarsolver.spec SRPM URL: https://mattia.fedorapeople.org/stellarsolver/stellarsolver-1.9-3.20220211git832bc60.fc37.src.rpm I had to provide both the desktop file and icons, I will submit them as a PR to upstream for inclusion.
Looks good, approved!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/stellarsolver
FEDORA-2022-a0e4ed3319 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a0e4ed3319
FEDORA-2022-a0e4ed3319 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.