Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2054882

Summary: sos report forgets to write --plugopts from /etc/sos/sos.conf to sos.log
Product: Red Hat Enterprise Linux 8 Reporter: Pavel Moravec <pmoravec>
Component: sosAssignee: Pavel Moravec <pmoravec>
Status: CLOSED ERRATA QA Contact: Maros Kopec <makopec>
Severity: high Docs Contact:
Priority: urgent    
Version: 8.6CC: agk, bmr, jhunsaker, jjansky, mhradile, plambri, pmoravec, sbradley, theute
Target Milestone: rcKeywords: Regression, Triaged
Target Release: 8.6Flags: pm-rhel: mirror+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: sos-4.2-14.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2054883 (view as bug list) Environment:
Last Closed: 2022-05-10 15:16:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2054883    

Description Pavel Moravec 2022-02-15 21:57:54 UTC
Description of problem:

/etc/sos/sos.conf :

[plugin_options]
# Specify any plugin options and their values here. These options take the form
# plugin_name.option_name = value
#rpm.rpmva = off
processor.timeout = 10
rpm.rpmva = off
ebpf.namespaces = 11


But:

sos report -o ebpf --batch --build -vvv | grep -e effective

prints:

[sos.report:setup] effective options now: --batch --build --only-plugins ebpf -vvv


Upstream is OK:

[sos.report:setup] effective options now: --batch --build --only-plugins ebpf --plugopts processor.timeout=10,rpm.rpmva=off,ebpf.namespaces=11 -vvv


This *needs* to be fixed into 8.6.


Version-Release number of selected component (if applicable):
sos-4.2-13


How reproducible:
100%


Steps to Reproduce:
See above


Actual results:


Expected results:


Additional info:

Comment 1 Jake Hunsaker 2022-02-15 22:03:38 UTC
Is this actually ignoring the plug opts, or just logging them wrong?

There was a logging issue fixed here: https://github.com/sosreport/sos/commit/5824cd5d3bddf39e0382d568419e2453abc93d8a

Comment 2 Pavel Moravec 2022-02-16 07:14:37 UTC
(In reply to Jake Hunsaker from comment #1)
> Is this actually ignoring the plug opts, or just logging them wrong?
> 
> There was a logging issue fixed here:
> https://github.com/sosreport/sos/commit/
> 5824cd5d3bddf39e0382d568419e2453abc93d8a

Good point. Indeed, it is just an improper logging, the options are applied properly:

# echo "qpid.port = 12345" >> /etc/sos/sos.conf

# sos report -o qpid --batch --build -vvv | grep -e effective -e /var/tmp/sosreport
[sos.report:setup] effective options now: --batch --build --only-plugins qpid -vvv
	/var/tmp/sosreport-pmoravec-rhel8-2022-02-16-hgonuqr
# grep -m1 qpid-stat /var/tmp/sosreport-pmoravec-rhel8-2022-02-16-hgonuqr/sos_logs/sos.log 
2022-02-16 07:59:13,531 DEBUG: [plugin:qpid] packed command: binary=False, changes=False, chroot=True, cmd='qpid-stat -g -b localhost:12345', cmd_as_tag=False, env=None, foreground=False, priority=10, root_symlink=None, runat=None, sizelimit=25, stderr=True, subdir=None, suggest_filename=None, tags=[], timeout=None
#

And I can confirmt the commit does fix it properly.

Still it is worth considering to add it to 8.6/9.0, as the "effective options now" is a good indicator how sos was really executed.

Comment 8 errata-xmlrpc 2022-05-10 15:16:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (sos bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:1998