Bug 205504 - Review Request: rum - rug-like interface for yum
Review Request: rum - rug-like interface for yum
Status: CLOSED WONTFIX
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ray Strode [halfline]
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2006-09-06 15:31 EDT by James Willcox
Modified: 2008-08-02 19:40 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-13 10:47:03 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description James Willcox 2006-09-06 15:31:48 EDT
Spec URL: http://www.snorp.net/files/rum/rum.spec
SRPM URL: http://www.snorp.net/files/rum/rum-1.0.0-1.src.rpm
Description: rum is a rug-like interface for yum
Comment 1 James Willcox 2006-09-06 15:36:11 EDT
Oops, I should mention that this is my first package and I would need a sponsor,
etc.
Comment 2 Ray Strode [halfline] 2006-09-06 16:01:32 EDT
So at first glance, the package spec file looks great.

Did you run it through rpmlint?  If so, any spew?
Comment 3 James Willcox 2006-09-06 16:11:56 EDT
Yeah, it gives me this:

W: rum summary-not-capitalized rum is a rug-like interface for yum
E: rum non-executable-script /usr/share/rum/rummain.py 0644
E: rum non-executable-script /usr/share/rum/i18n.py 0644
E: rum zero-length /usr/share/doc/rum-1.0.0/ChangeLog

All of that seems fairly benign to me, but what do I know :)
Comment 4 Ray Strode [halfline] 2006-09-06 16:24:49 EDT
cool. And the srpm builds okay in mock? If so, seems fine.
Comment 5 Jason Tibbitts 2006-09-06 16:29:24 EDT
In general you shouldn't package zero length files.

Also, the description is somewhat lacking.  Even if it's supposed that I know
what "yum" is, I have little chance of knowing what "rug" might be.
Comment 6 James Willcox 2006-09-06 16:51:37 EDT
Ok, I changed the description to:

rum is a rug-like interface for yum (Yellowdog Updater Modified).  rug is the
command-line frontend for rcd (Red Carpet Daemon).

And removed the empty ChangeLog
Comment 7 James Willcox 2006-09-06 16:53:38 EDT
Bah, I meant:

rum is a rug-like interface for yum (Yellow dog Updater, Modified).  rug is the
command-line frontend for rcd (Red Carpet Daemon).
Comment 8 Ray Strode [halfline] 2006-09-07 15:34:34 EDT
Let me know when you've created an account, sent in the CLA, etc, and I'll move
you over to sponsored status.
Comment 9 Brian Pepple 2006-09-07 16:19:19 EDT
Quick note:  the Source should be a full url.
Comment 10 Chitlesh GOORAH 2006-09-08 05:34:42 EDT
** I've seen you have updated the src.rpm
Next time, do update the release version as well.

** 
%defattr(-,root,root,-)
%defattr(-,root,root)

Duplicates

**
chitlesh(rum-1.0.0-1)[0]$rpmlint /home/chitlesh/rpmbuild/SRPMS/rum-1.0.0-1.src.rpm
W: rum summary-not-capitalized rum is a rug-like interface for yum

Capitalized the "R" of "rum"

E: rum description-line-too-long rum is a rug-like interface for yum (Yellow dog
Updater, Modified).  rug is the command-line frontend for rcd (Red Carpet Daemon).

Divide it into 2 lines

** 
 /usr/bin/install -c -m 644 'i18n.py'
'/var/tmp/rum-1.0.0-1-root-chitlesh/usr/share/rum/i18n.py'
 /usr/bin/install -c -m 644 'rumcommand.py'
'/var/tmp/rum-1.0.0-1-root-chitlesh/usr/share/rum/rumcommand.py'
 /usr/bin/install -c -m 644 'rummain.py'
'/var/tmp/rum-1.0.0-1-root-chitlesh/usr/share/rum/rummain.py'                       

preserves the files' timestamps
make INSTALL="install -p" install DESTDIR=$RPM_BUILD_ROOT

** Like Brian said : the Source should be a full url.
Comment 11 Rahul Sundaram 2007-03-13 10:40:06 EDT
James Willcox,

Are you interested in this package anymore? Its been stalled for a long time now.
Comment 12 James Willcox 2007-03-13 10:47:03 EDT
No, we should close it.  I haven't taken the time to get the CLA approved by my
employer, and I haven't worked on rum in quite a while.

Note You need to log in before you can comment on or make changes to this bug.