Spec URL: https://download.copr.fedorainfracloud.org/results/luya/fxx-backgrounds/fedora-rawhide-x86_64/03512353-f36-backgrounds/f36-backgrounds.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/luya/fxx-backgrounds/fedora-rawhide-x86_64/03512353-f36-backgrounds/f36-backgrounds-36.0.0-1.fc37.src.rpm Description: This package contains desktop backgrounds for the Fedora 36 default theme. Pulls in themes for GNOME, KDE, Mate and Xfce desktops. Fedora Account System Username:luya
For an easy review process, use https://download.copr.fedorainfracloud.org/results/luya/fxx-backgrounds/fedora-rawhide-x86_64/03512353-f36-backgrounds/fedora-review/review.txt as guideline.
Proposed as a Blocker for 36-beta by Fedora user luya using the blocker tracking app because: This report requires a review process to package the default wallpapers for Fedora 36 Beta.
Removing the proposed blocker status as, strictly speaking, it's not a blocker. But it blocks BZ 2052654, which makes it a transitive blocker. :-) Since we're not in freeze yet, this is somewhat academic anyway.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= [-] Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Creative Commons Attribution-ShareAlike 4.0", "Creative Commons Attribution 4.0", "Unknown or generated", "*No copyright* Creative Commons CC0 1.0", "*No copyright* Free Art License 1.3", "*No copyright* Creative Commons Attribution-ShareAlike". 22 files have unknown license. Detailed output of licensecheck in /home/bcotton/fedora/reviews/2055105-f36-backgrounds/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mate-background- properties, /usr/share/backgrounds/f36, /usr/share/wallpapers, /usr/share/gnome-background-properties, /usr/share/xfce4 [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/plasma(f30-backgrounds-kde, f26-backgrounds-kde, f32-backgrounds-kde, f33-backgrounds-kde, f31-backgrounds-kde, f27-backgrounds-kde, f28-backgrounds-kde, f25-backgrounds-kde, f35-backgrounds-kde, f29-backgrounds-kde, f34-backgrounds-kde, kf5-plasma), /usr/share/plasma/desktoptheme(f30-backgrounds-kde, f26-backgrounds-kde, f32-backgrounds-kde, f33-backgrounds-kde, f31-backgrounds-kde, f27-backgrounds-kde, f28-backgrounds-kde, f25-backgrounds-kde, f35-backgrounds-kde, plasma-desktop, f29-backgrounds-kde, f34-backgrounds-kde, kf5-plasma), /usr/share/mate-background-properties(f32-backgrounds-mate, adapta- backgrounds, f28-backgrounds-mate, mate-backgrounds, f31-backgrounds- mate, fedorainfinity-backgrounds, desktop-backgrounds-basic, f34-backgrounds-mate, f30-backgrounds-mate, f35-backgrounds-mate, f33-backgrounds-mate, f29-backgrounds-mate), /usr/share/xfce4/backdrops(f32-backgrounds-extras-xfce, f29-backgrounds-extras-xfce, f31-backgrounds-xfce, f28-backgrounds- xfce, f28-backgrounds-extras-xfce, f33-backgrounds-extras-xfce, f29-backgrounds-xfce, f32-backgrounds-xfce, f30-backgrounds-xfce, f33-backgrounds-xfce, f34-backgrounds-xfce, f30-backgrounds-extras- xfce, f34-backgrounds-extras-xfce, f31-backgrounds-extras-xfce, f35-backgrounds-xfce, f35-backgrounds-extras-xfce), /usr/share/xfce4(f31-backgrounds-xfce, f28-backgrounds-xfce, f33-backgrounds-xfce, f34-backgrounds-xfce, f29-backgrounds-xfce, f32-backgrounds-xfce, f30-backgrounds-xfce, f35-backgrounds-xfce), /usr/share/gnome-background-properties(fedora-workstation-backgrounds, neon-backgrounds, f28-backgrounds-gnome, f35-backgrounds-gnome, adapta-backgrounds, f30-backgrounds-gnome, f33-backgrounds-gnome, f34-backgrounds-gnome, f31-backgrounds-gnome, fedorainfinity- backgrounds, desktop-backgrounds-basic, f32-backgrounds-gnome, gears- backgrounds, solar-backgrounds, f29-backgrounds-gnome) [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in f36-backgrounds-base , f36-backgrounds-gnome , f36-backgrounds-kde , f36-backgrounds-mate , f36-backgrounds-xfce , f36-backgrounds-extras- base , f36-backgrounds-extras-gnome , f36-backgrounds-extras-mate , f36-backgrounds-extras-kde , f36-backgrounds-extras-xfce [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
The two fails for file/directory ownership seem to be consistent across previous versions of this package. So while they should be cleaned up at some point, I don't see a need to block the review on this. Setting to approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/f36-backgrounds
Package is now stable: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c4994a2065