Spec URL: https://download.copr.fedorainfracloud.org/results/slp/rust-virtio-queue/fedora-36-x86_64/03516575-rust-virtio-queue/rust-virtio-queue.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/slp/rust-virtio-queue/fedora-36-x86_64/03516575-rust-virtio-queue/rust-virtio-queue-0.1.0-1.fc36.src.rpm Description: Virtio queue implementation Fedora Account System Username: slp
Two quick notes from Rust packaging POV: 1. The package and crate does not contain license files. You should poke upstream project to include them in published crates. Until that is resolved, you will probably need to include the two license files as additional SOURCEs and add them manually. 2. %cargo_test "--features" test-utils This looks weird, not sure if that even works as expected. The %cargo_test macro even has an "-f" flag for this exact use case: %cargo_test -f test-utils
(In reply to Fabio Valentini from comment #1) > Two quick notes from Rust packaging POV: > > 1. The package and crate does not contain license files. > You should poke upstream project to include them in published crates. > Until that is resolved, you will probably need to include the two license > files as additional SOURCEs and add them manually. That's the result of this crate being in a shared repository. I'll let upstream know. I think fixing it should be as simple as adding some "license_file" entries in this crate's Cargo.toml. I've added the files as addition SOURCEs, pointing to URLs where the license files reside in the shared repository. > 2. %cargo_test "--features" test-utils > > This looks weird, not sure if that even works as expected. > The %cargo_test macro even has an "-f" flag for this exact use case: > > %cargo_test -f test-utils It works, but I agree it's weird. I've fixed it too. https://download.copr.fedorainfracloud.org/results/slp/rust-virtio-queue/fedora-36-x86_64/03517131-rust-virtio-queue/rust-virtio-queue.spec https://download.copr.fedorainfracloud.org/results/slp/rust-virtio-queue/fedora-36-x86_64/03517131-rust-virtio-queue/rust-virtio-queue-0.1.0-1.fc36.src.rpm Thanks for the review!
Fabio, could you please confirm if I have addressed properly your concerns? Thanks! Sergio.
Yes. Sorry, I did not mean to start a formal review, because I'm quite short on time recently. But to not keep you waiting any further, I've finished the review regardless. The package looks good now. Just make sure to alert the upstream project about the missing license files. You might also want to create bugs for the missing architecture support, and make them block the appropriate tracker/blocker bugs. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-virtio-queue
Package has hit the compose. Thanks Fabio and Gwyn!