Bug 2055411 - Helm release list page should only fetch secrets for deployed charts
Summary: Helm release list page should only fetch secrets for deployed charts
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.7
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.7.z
Assignee: Christoph Jerolimov
QA Contact: spathak@redhat.com
URL:
Whiteboard:
Depends On: 2046215
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-02-16 20:47 UTC by Christoph Jerolimov
Modified: 2022-05-12 18:12 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-12 18:12:28 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Helm Releases list page showing correctly (186.63 KB, image/png)
2022-04-08 09:07 UTC, Yadan Pei
no flags Details
Topology view empty (147.26 KB, image/png)
2022-04-08 09:08 UTC, Yadan Pei
no flags Details
tested-on-4.7.47.mp4 (2.39 MB, video/mp4)
2022-04-25 13:49 UTC, Christoph Jerolimov
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 11078 0 None open [release-4.7] Bug 2055411: Filter superseded helm secrets and fix firehose to support partial metadata 2022-02-16 20:49:46 UTC
Red Hat Product Errata RHBA-2022:1698 0 None None None 2022-05-12 18:12:37 UTC

Description Christoph Jerolimov 2022-02-16 20:47:25 UTC
+++ This bug was initially created as a copy of Bug #2046215 +++

+++ This bug was initially created as a copy of Bug #2044292 +++

+++ This bug was initially created as a copy of Bug #2039315 +++

Description of problem: Helm release list page and topology page fetches all the secrets for helm release that are not deployed.


Version-Release number of selected component (if applicable):


How reproducible: Always


Steps to Reproduce:
1. Install a helm chart from the catalog.
2. Upgrade or rollback the helm release a few times.
3. Go to helm release list page or topology.

Actual results: List page fetches all the secrets.


Expected results: It should only fetch the latest revision of the release.


Additional info:

Comment 4 Yadan Pei 2022-04-08 09:06:38 UTC
1. Install a helm chart from the catalog.
2. Upgrade or rollback the helm release a few times.
3. Go to helm release list page or topology, the request to get secrets are 
GET https://console-openshift-console.apps.ci-ln-419v1zt-72292.origin-ci-int-gce.dev.rhcloud.com/api/kubernetes/api/v1/namespaces/yapei-test/secrets?limit=250&labelSelector=owner=helm,status!=superseded

it is using labelSelector owner=helm,status!=superseded instead of loading all secrets in the namespace

However 'Topology' view doesn't show HelmReleases, just empty

Assigning back for further investigation

^^ steps are checked against 4.7.47

Comment 5 Yadan Pei 2022-04-08 09:07:43 UTC
Created attachment 1871427 [details]
Helm Releases list page showing correctly

Comment 6 Yadan Pei 2022-04-08 09:08:11 UTC
Created attachment 1871428 [details]
Topology view empty

Comment 7 Christoph Jerolimov 2022-04-25 13:49:07 UTC
Created attachment 1874816 [details]
tested-on-4.7.47.mp4

Comment 8 Christoph Jerolimov 2022-04-25 13:55:42 UTC
I tested this by also starting a 4.7.47 cluster

I installed two helm charts which I can see in the helm list and the topology. I also verified that the helm response doesn't contain any data. See attached screen recording.

The topology looks stuck to me because it shows nighter a loading indicator, data, nor the empty state. It just shows nothing here: https://bugzilla-attachments.redhat.com/attachment.cgi?id=1871428, I expect the reason is some pending network calls.

We have another issue for this stuck topology: https://issues.redhat.com/browse/ODC-6056

The issue described in this bug and the backports work fine for me. For this, I would like to set this ticket as verified. But feel free to reopen it if you don't agree.

Comment 11 errata-xmlrpc 2022-05-12 18:12:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.7.50 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1698


Note You need to log in before you can comment on or make changes to this bug.