Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:
Currently "Ansible Roles - Install from git" job template uses the `command` module for cloning git repos. We should be using the native "git" ansible module for idempotency.

Version-Release number of selected component (if applicable):
All supported Satellite versions

How reproducible:
100%

Steps to Reproduce:

Check the "Ansible Roles - Install from git" role code

~~~
---
- hosts: all
  tasks:
    - command: git clone <%= input('git_repository') %> <%= input('location') %>
      register: out
    - debug: var=out
~~~


Actual results:
Command module is currently in use

Expected results:
We should be using the git module https://docs.ansible.com/ansible/2.9/modules/git_module.html

Additional info:

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/34652 has been resolved.

This is fixed in upstream, do we want to pull it in?

I'd say it's a low prio and can wait for a regular rebase.

Verified.

Tested on Satellite 6.12.0 Snap 4.0

Observation: 
"Ansible Roles - Install from git" now uses the  "git" ansible module

~~~
---
- hosts: all
  tasks:
    - git:
        repo: "<%= input('git_repository') %>"
        dest: "<%= input('location') %>"
      register: out

    - debug: var=out
~~~

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.12 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8506