Bug 2056006 - Review Request: golang-github-bradenhilton-mozillainstallhash - Generate differentiating hash between Mozilla software installs
Summary: Review Request: golang-github-bradenhilton-mozillainstallhash - Generate diff...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Anthony Rabbito
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2120465 (view as bug list)
Depends On: 2056007
Blocks: 2130734
TreeView+ depends on / blocked
 
Reported: 2022-02-18 10:44 UTC by Elliott Sales de Andrade
Modified: 2022-11-10 22:15 UTC (History)
2 users (show)

Fixed In Version: golang-github-bradenhilton-mozillainstallhash-1.0.0-1.fc38
Clone Of:
Environment:
Last Closed: 2022-10-20 15:19:38 UTC
Type: ---
Embargoed:
hello: fedora-review+


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2022-02-18 10:44:24 UTC
Spec URL: https://qulogic.fedorapeople.org/golang-github-bradenhilton-mozillainstallhash.spec
SRPM URL: https://qulogic.fedorapeople.org/golang-github-bradenhilton-mozillainstallhash-1.0.0-1.fc34.src.rpm

Description:

Go package which generates the hash used to differentiate between installs of
Mozilla software.

Fedora Account System Username: qulogic

Comment 1 Elliott Sales de Andrade 2022-02-18 11:19:46 UTC
scratch build + review: https://copr.fedorainfracloud.org/coprs/build/3528987

Comment 2 Elliott Sales de Andrade 2022-03-06 20:41:33 UTC
Updated scratch build + review: https://copr.fedorainfracloud.org/coprs/qulogic/Reviews/build/3633774/

Comment 3 Anthony Rabbito 2022-09-28 18:54:13 UTC
*** Bug 2120465 has been marked as a duplicate of this bug. ***

Comment 4 Anthony Rabbito 2022-10-07 23:26:00 UTC
Hi Elliott there's a summary mismatch between the SRPM and spec file. Do you mind making them the same?


```
-Summary:        Generate differentiating hash between Mozilla software installs
+Summary:        Go package which generates the hash used to differentiate between installs of Mozilla software
```

Otherwise spec looks good. You can optionally regenerate with go2rpm to adopt to the new style.

Comment 5 Elliott Sales de Andrade 2022-10-10 06:42:02 UTC
Thank you for the review, Anthony

https://pagure.io/releng/fedora-scm-requests/issue/48096

Comment 6 Elliott Sales de Andrade 2022-10-10 06:42:58 UTC
OK, will do that on import.

Comment 7 Gwyn Ciesla 2022-10-10 13:42:55 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bradenhilton-mozillainstallhash

Comment 8 Fedora Update System 2022-10-11 22:22:41 UTC
FEDORA-2022-697935ee78 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-697935ee78

Comment 9 Fedora Update System 2022-10-11 22:22:42 UTC
FEDORA-2022-108d2998f3 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-108d2998f3

Comment 10 Fedora Update System 2022-10-12 09:38:55 UTC
FEDORA-2022-108d2998f3 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-108d2998f3 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-108d2998f3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-10-12 13:02:33 UTC
FEDORA-2022-697935ee78 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-697935ee78 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-697935ee78

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-10-20 15:19:38 UTC
FEDORA-2022-697935ee78 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-11-10 22:15:57 UTC
FEDORA-2022-108d2998f3 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.