Spec URL: https://ngompa.fedorapeople.org/for-review/netplan.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/netplan-0.104-1.fc35.src.rpm Description: netplan reads network configuration from /etc/netplan/*.yaml which are written by administrators, installers, cloud image instantiations, or other OS deployments. During early boot, it generates backend specific configuration files in /run to hand off control of devices to a particular networking daemon. Fedora Account System Username: ngompa
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 3", "*No copyright* GNU General Public License, Version 3". 56 files have unknown license. Detailed output of licensecheck in /home/pihhan/fedora/review/2056247-netplan/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dbus-1, /usr/share/dbus-1/system.d, /usr/share/dbus-1/system-services Should Requires: dbus-common [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. Note: see dbus-1 directory above [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 112640 bytes in 27 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in netplan- libs , netplan-devel , netplan-default-backend-NetworkManager , netplan-default-backend-networkd [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 3.0 starting (python version = 3.10.4, NVR = mock-3.0-1.fc35)... Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start(bootstrap): chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 3.0 INFO: Mock Version: 3.0 Finish(bootstrap): chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 3.0 INFO: Mock Version: 3.0 Finish: chroot init INFO: installing package(s): /builddir/netplan-debuginfo-0.104-1.fc37.x86_64.rpm /builddir/netplan-debugsource-0.104-1.fc37.x86_64.rpm /builddir/netplan-devel-0.104-1.fc37.x86_64.rpm /builddir/netplan-default-backend-NetworkManager-0.104-1.fc37.noarch.rpm /builddir/netplan-libs-0.104-1.fc37.x86_64.rpm /builddir/netplan-0.104-1.fc37.x86_64.rpm /builddir/netplan-default-backend-networkd-0.104-1.fc37.noarch.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 15616a3eb4194e368d752ec92ce7359e -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.kgs9pyo6:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 37 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /builddir/netplan-debuginfo-0.104-1.fc37.x86_64.rpm /builddir/netplan-debugsource-0.104-1.fc37.x86_64.rpm /builddir/netplan-devel-0.104-1.fc37.x86_64.rpm /builddir/netplan-default-backend-NetworkManager-0.104-1.fc37.noarch.rpm /builddir/netplan-libs-0.104-1.fc37.x86_64.rpm /builddir/netplan-0.104-1.fc37.x86_64.rpm /builddir/netplan-default-backend-networkd-0.104-1.fc37.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/canonical/netplan/archive/0.104/netplan-0.104.tar.gz : CHECKSUM(SHA256) this package : 930a43d8a0a9f5c61193ce2546cacf311c8a0d66003ad96a1e20fcc10a5fdbc9 CHECKSUM(SHA256) upstream package : 930a43d8a0a9f5c61193ce2546cacf311c8a0d66003ad96a1e20fcc10a5fdbc9 Requires -------- netplan (rpmlib, GLIBC filtered): /usr/bin/python3 /usr/sbin/ip libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libnetplan.so.0.0()(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_221)(64bit) libsystemd.so.0(LIBSYSTEMD_243)(64bit) netplan-default-backend netplan-libs(x86-64) python3.10dist(netifaces) python3.10dist(pyyaml) rtld(GNU_HASH) netplan-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libyaml-0.so.2()(64bit) rtld(GNU_HASH) netplan-devel (rpmlib, GLIBC filtered): libnetplan.so.0.0()(64bit) netplan-libs(x86-64) netplan-default-backend-NetworkManager (rpmlib, GLIBC filtered): NetworkManager NetworkManager-config-server netplan netplan-default-backend-networkd (rpmlib, GLIBC filtered): netplan systemd-networkd netplan-debuginfo (rpmlib, GLIBC filtered): netplan-debugsource (rpmlib, GLIBC filtered): Provides -------- netplan: netplan netplan(x86-64) netplan.io netplan.io(x86-64) netplan-libs: libnetplan.so.0.0()(64bit) netplan-libs netplan-libs(x86-64) netplan-devel: netplan-devel netplan-devel(x86-64) netplan-default-backend-NetworkManager: netplan-default-backend netplan-default-backend-NetworkManager netplan-default-backend-networkd: netplan-default-backend netplan-default-backend-networkd netplan-debuginfo: debuginfo(build-id) netplan-debuginfo netplan-debuginfo(x86-64) netplan-debugsource: netplan-debugsource netplan-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2056247 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Ocaml, Haskell, SugarActivity, Perl, PHP, Java, fonts, Python, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
> INFO: installing package(s): /builddir/netplan-debuginfo-0.104-1.fc37.x86_64.rpm /builddir/netplan-debugsource-0.104-1.fc37.x86_64.rpm /builddir/netplan-devel-0.104-1.fc37.x86_64.rpm /builddir/netplan-default-backend-NetworkManager-0.104-1.fc37.noarch.rpm /builddir/netplan-libs-0.104-1.fc37.x86_64.rpm /builddir/netplan-0.104-1.fc37.x86_64.rpm /builddir/netplan-default-backend-networkd-0.104-1.fc37.noarch.rpm > ERROR: Command failed: > # /usr/bin/systemd-nspawn -q -M 15616a3eb4194e368d752ec92ce7359e -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.kgs9pyo6:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 37 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /builddir/netplan-debuginfo-0.104-1.fc37.x86_64.rpm /builddir/netplan-debugsource-0.104-1.fc37.x86_64.rpm /builddir/netplan-devel-0.104-1.fc37.x86_64.rpm /builddir/netplan-default-backend-NetworkManager-0.104-1.fc37.noarch.rpm /builddir/netplan-libs-0.104-1.fc37.x86_64.rpm /builddir/netplan-0.104-1.fc37.x86_64.rpm /builddir/netplan-default-backend-networkd-0.104-1.fc37.noarch.rpm --setopt=tsflags=nocontexts This is expected, since two subpackages are mutually conflicting and only one of them can be installed at a time.
I've updated the package to add the missing "Requires: dbus-common" dependency. I think this should be in good shape to approve now. Spec URL: https://ngompa.fedorapeople.org/for-review/netplan.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/netplan-0.104-1.fc35.src.rpm
Bah, wrong URL for SRPM... Spec URL: https://ngompa.fedorapeople.org/for-review/netplan.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/netplan-0.104-1.fc36.src.rpm
Okay, seem seem fine. I have nothing more to add. Thanks for the new package!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/netplan
Built in rawhide, f38, f37 and even epel{8,9}