Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-mroach-rom64/golang-github-mroach-rom64.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-mroach-rom64/golang-github-mroach-rom64-0.5.0-1.fc37.src.rpm Description: Nintendo 64 ROM utility written in Go: - List information about all ROMs in a directory - Show information about a single ROM - Convert a ROM file to the native (Z64, Big-endian) format - Validate the ROM's SHA-1 checksum against a list of known-good ROM dumps. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=83135872
Hi Davide, The spec is correct. I've two comments: - Package could be named rom64 rather than golang-github-mroach-rom64. If you want to do so, rename the BZ, the spec and define goname as done for example in `doctl` package. - Package has no tests, so %check section could be removed, but I think it's better to keep it in case future releases have any test. Let me know if you decide to change the name or not and will approve later.
Thanks! I prefer to keep the source package named golang-github-mroach-rom64 to make this easier to update in the future with go2rpm; the binary package is named rom64 already. Likewise for the check section.
Understood Davide. go2rpm package, fedora-review is correct: - The specfile is sane - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes (no tests available currently) - The latest version is packaged - The package complies with the Packaging Guidelines Package approved! On import, don't forget to do the following: - Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket.
Thanks! $ fedpkg request-repo golang-github-mroach-rom64 2056663 https://pagure.io/releng/fedora-scm-requests/issue/43057
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-mroach-rom64
FEDORA-2022-e29ed2ce37 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e29ed2ce37
FEDORA-2022-e29ed2ce37 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-d65b4fc232 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d65b4fc232
FEDORA-2022-48ce7d2489 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-48ce7d2489
FEDORA-2022-48ce7d2489 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-48ce7d2489 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-48ce7d2489 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-d65b4fc232 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d65b4fc232 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d65b4fc232 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-d65b4fc232 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-48ce7d2489 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.