Bug 2056893 - incorrect warning for --to-image in oc adm upgrade help
Summary: incorrect warning for --to-image in oc adm upgrade help
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: oc
Version: 4.11
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.11.0
Assignee: W. Trevor King
QA Contact: zhou ying
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-02-22 10:04 UTC by Evgeni Vakhonin
Modified: 2022-08-10 10:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-10 10:50:45 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift oc pull 1078 0 None Merged Bug 2056893: pkg/cli/admin/upgrade: Drop --to-image help warning 2022-03-16 19:06:52 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 10:51:02 UTC

Description Evgeni Vakhonin 2022-02-22 10:04:03 UTC
help description for oc adm upgrade warns:
      --to-image='': Provide a release image to upgrade to. WARNING: This option does not check for upgrade compatibility and may break your cluster.

this warning however became incorrect since the introduction of --allow-explicit-upgrade

How reproducible:
100%

Steps to Reproduce:
oc adm upgrade --help | grep " --to-image=''"

Actual results:
      --to-image='': Provide a release image to upgrade to. WARNING: This option does not check for upgrade compatibility and may break your cluster.

Expected results:
the help message should be according to the functionality

Comment 3 Evgeni Vakhonin 2022-03-17 17:38:51 UTC
Reproducing:

Client Version: 4.11.0-0.nightly-2022-03-13-055724

<-snip->
 If there are no versions available, or a bug in the cluster version operator prevents updates from being retrieved, the
more powerful and dangerous --to-image=IMAGE option may be used. This instructs the cluster to upgrade to the contents
of the specified release image, regardless of whether that upgrade is safe to apply to the current version. 
</-snip->

<-snip->
      --to-image='': Provide a release image to upgrade to. WARNING: This option does not check for upgrade
compatibility and may break your cluster.
</-snip->





Verifying:
Client Version: 4.11.0-0.nightly-2022-03-15-223029

<-snip->
 If there are no versions available, or a bug in the cluster version operator prevents updates from being retrieved,
--to-image may be combined with the more powerful and dangerous --allow-explicit-upgrade. This instructs the cluster to
upgrade to the contents of the specified release image, regardless of whether that upgrade is known to be recommended
for the current version.
</-snip->

<-snip->
      --to-image='': Provide a release image to upgrade to.
</-snip->



as expected!

Comment 5 errata-xmlrpc 2022-08-10 10:50:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069


Note You need to log in before you can comment on or make changes to this bug.