commit b2df459e495165eca56f47d59fe3bb3c4efddc33
Merge: bba08b536 dcde9771c
Author: Open vSwitch CI <ovs-ci>
Date:   Wed Feb 16 18:04:20 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    dcde9771c5 ovsdb-idl: Fix use-after-free when destroying an IDL loop.

commit bba08b53639592134ccedfd6a478a6543b9504fd
Merge: 7b6570c65 8e23c06f2
Author: Open vSwitch CI <ovs-ci>
Date:   Wed Feb 16 10:47:28 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    8e23c06f24 dpif-netdev-dpcls: Make subtable reprobe thread-safe.
    ac0e3dd3ba ci: Fix typo in variable name.
    fc25e0397a dp-packet: Ensure packet base is always non-NULL.
    dbae56e702 bfd: lldp: stp: Fix misaligned packet field access.
    ee17b06cf9 ovsdb-idlc: Avoid accessing member within NULL idl index cursors.
    1d799a5d17 stopwatch: Fix buffer underflow when computing percentiles.

commit 7b6570c65fef3c92179b44d8bf3ba5771de67b3a
Merge: c5ad7f71c 0954c2911
Author: Open vSwitch CI <ovs-ci>
Date:   Wed Feb 9 18:34:54 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    0954c2911d ofproto: Fix ipfix not always sampling on egress. (#2016346)

commit c5ad7f71c501b73363f7c655cfa1a837a318afc8
Merge: 4541c91b9 867e586b4
Author: Open vSwitch CI <ovs-ci>
Date:   Wed Feb 9 10:49:07 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    867e586b45 tc: Fix incorrect TC rule for decap+encap datapath flow.

commit 4541c91b99c91846aad97360a0ab6e67b78d337b
Merge: 9d5178514 418e6a0b8
Author: Open vSwitch CI <ovs-ci>
Date:   Tue Feb 8 06:33:35 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    418e6a0b8e dpif-netdev: fix vlan and ipv4 parsing in avx512

commit 9d51785142f08095148dbf14a9ff2717a8ac25d7
Merge: 6e6f66ffd 1ec567a75
Author: Michael Santana <msantana>
Date:   Mon Feb 7 11:14:16 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    1ec567a752 ci: Install wheel before installing any other python packages.
    031a99cef0 odp-util: Fix tunnel key attr for GTP-U.
    558699c73c ovsdb-idl: Only process successful txn in ovsdb_idl_loop_run.

commit 6e6f66ffd0ec53c320254c66eba622b401dfec74
Merge: 513117cbb 0276bdb30
Author: Open vSwitch CI <ovs-ci>
Date:   Wed Feb 2 17:06:21 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    0276bdb30a ofproto-dpif-upcall: Fix n_revalidators on upcall show.

commit 513117cbb0f406144ff2093f550edbc2eb7ed945
Merge: 7665f42d1 16575362d
Author: Open vSwitch CI <ovs-ci>
Date:   Wed Feb 2 11:33:45 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    16575362dc acinclude: Detect avx512 vpopcntdq compiler support.

commit 7665f42d12190c7cdc8392c8bfa11713eb7b2a49
Author: Ilya Maximets <i.maximets>
Date:   Sun Dec 19 15:09:38 2021 +0100

    ovsdb: transaction: Keep one entry in the transaction history.
    
    commit 6e13565dd32fb2cf5517f51ca06956e2052c4bba
    Author: Ilya Maximets <i.maximets>
    Date:   Sun Dec 19 15:09:38 2021 +0100
    
        ovsdb: transaction: Keep one entry in the transaction history.
    
        If a single transaction exceeds the size of the whole database (e.g.,
        a lot of rows got removed and new ones added), transaction history will
        be drained.  This leads to sending UUID_ZERO to the clients as the last
        transaction id in the next monitor update, because monitor doesn't
        know what was the actual last transaction id.  In case of a re-connect
        that will cause re-downloading of the whole database, since the
        client's last_id will be out of sync.
    
        One solution would be to store the last transaction ID separately
        from the actual transactions, but that will require a careful
        management in cases where database gets reset and the history needs
        to be cleared.  Keeping the one last transaction instead to avoid
        the problem.  That should not be a big concern in terms of memory
        consumption, because this last transaction will be removed from the
        history once the next transaction appeared.  This is also not a concern
        for a fast re-sync, because this last transaction will not be used
        for the monitor reply; it's either client already has it, so no need
        to send, or it's a history miss.
    
        The test updated to not check the number of atoms if there is only
        one transaction in the history.
    
        Fixes: 317b1bfd7dd3 ("ovsdb: Don't let transaction history grow larger than the database.")
        Acked-by: Mike Pattrick <mkp>
        Acked-by: Han Zhou <hzhou>
        Signed-off-by: Ilya Maximets <i.maximets>
    
    Reported-at: https://bugzilla.redhat.com/2044621
    Signed-off-by: Ilya Maximets <i.maximets>

commit d202cd6da14a28cafa69612dc90678118ce5dbc7
Merge: abe61535c 34c830c54
Author: Open vSwitch CI <ovs-ci>
Date:   Mon Jan 31 18:49:06 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    34c830c540 ovsdb-idl: ovsdb_idl_loop_destroy must also destroy the committing txn.
    13009736b2 ovsdb-cs: Clear last_id on reconnect if condition changes in-flight.
    017e2ae50e ofp-flow: Skip flow reply if it exceeds the maximum message size.
    e0c6f92a95 ovsdb-cs: Fix ignoring of the last id from the initial monitor reply. (#2044624)

commit abe61535cadcd924ad1455c505ebd8efc40464b4
Author: Ilya Maximets <i.maximets>
Date:   Mon Dec 13 16:43:33 2021 +0100

    ovsdb: storage: Randomize should_snapshot checks when the minimum time passed.
    
    commit 339f97044e3c2312fbb65b932fa14a181acf40d5
    Author: Ilya Maximets <i.maximets>
    Date:   Mon Dec 13 16:43:33 2021 +0100
    
        ovsdb: storage: Randomize should_snapshot checks when the minimum time passed.
    
        Snapshots are scheduled for every 10-20 minutes.  It's a random value
        in this interval for each server.  Once the time is up, but the maximum
        time (24 hours) not reached yet, ovsdb will start checking if the log
        grew a lot on every iteration.  Once the growth is detected, compaction
        is triggered.
    
        OTOH, it's very common for an OVSDB cluster to not have the log growing
        very fast.  If the log didn't grow 2x in 20 minutes, the randomness of
        the initial scheduled time is gone and all the servers are checking if
        they need to create snapshot on every iteration.  And since all of them
        are part of the same cluster, their logs are growing with the same
        speed.  Once the critical mass is reached, all the servers will start
        creating snapshots at the same time.  If the database is big enough,
        that might leave the cluster unresponsive for an extended period of
        time (e.g. 10-15 seconds for OVN_Southbound database in a larger scale
        OVN deployment) until the compaction completed.
    
        Fix that by re-scheduling a quick retry if the minimal time already
        passed.  Effectively, this will work as a randomized 1-2 min delay
        between checks, so the servers will not synchronize.
    
        Scheduling function updated to not change the upper limit on quick
        reschedules to avoid delaying the snapshot creation indefinitely.
        Currently quick re-schedules are only used for the error cases, and
        there is always a 'slow' re-schedule after the successful compaction.
        So, the change of a scheduling function doesn't change the current
        behavior much.
    
        Signed-off-by: Ilya Maximets <i.maximets>
        Acked-by: Han Zhou <hzhou>
        Acked-by: Dumitru Ceara <dceara>
    
    Reported-at: https://bugzilla.redhat.com/2044614
    Signed-off-by: Ilya Maximets <i.maximets>

commit 915efc8c00f1c9a88bc996a65f31c525109983a4
Author: Dumitru Ceara <dceara>
Date:   Mon Dec 13 20:46:03 2021 +0100

    raft: Only allow followers to snapshot.
    
    commit bf07cc9cdb2f37fede8c0363937f1eb9f4cfd730
    Author: Dumitru Ceara <dceara>
    Date:   Mon Dec 13 20:46:03 2021 +0100
    
        raft: Only allow followers to snapshot.
    
        Commit 3c2d6274bcee ("raft: Transfer leadership before creating
        snapshots.") made it such that raft leaders transfer leadership before
        snapshotting.  However, there's still the case when the next leader to
        be is in the process of snapshotting.  To avoid delays in that case too,
        we now explicitly allow snapshots only on followers.  Cluster members
        will have to wait until the current election is settled before
        snapshotting.
    
        Given the following logs taken from an OVN_Southbound 3-server cluster
        during a scale test:
    
        S1 (old leader):
          19:07:51.226Z|raft|INFO|Transferring leadership to write a snapshot.
          19:08:03.830Z|ovsdb|INFO|OVN_Southbound: Database compaction took 12601ms
          19:08:03.940Z|raft|INFO|server 8b8d is leader for term 43
    
        S2 (follower):
          19:08:00.870Z|raft|INFO|server 8b8d is leader for term 43
    
        S3 (new leader):
          19:07:51.242Z|raft|INFO|received leadership transfer from f5c9 in term 42
          19:07:51.244Z|raft|INFO|term 43: starting election
          19:08:00.805Z|ovsdb|INFO|OVN_Southbound: Database compaction took 9559ms
          19:08:00.869Z|raft|INFO|term 43: elected leader by 2+ of 3 servers
    
        We see that the leader to be (S3) receives the leadership transfer,
        initiates the election and immediately after starts a snapshot that
        takes ~9.5 seconds.  During this time, S2 votes for S3 electing it
        as cluster leader but S3 doesn't effectively become leader until it
        finishes snapshotting, essentially keeping the cluster without a
        leader for up to ~9.5 seconds.
    
        With the current change, S3 will delay compaction and snapshotting until
        the election is finished.
    
        The only exception is the case of single-node clusters for which we
        allow the node to snapshot regardless of role.
    
        Acked-by: Han Zhou <hzhou>
        Signed-off-by: Dumitru Ceara <dceara>
        Signed-off-by: Ilya Maximets <i.maximets>
    
    Reported-at: https://bugzilla.redhat.com/2044614
    Signed-off-by: Ilya Maximets <i.maximets>

commit f1ca7b8ac32b3acc7844d22862c28f3d0586536e
Merge: 60b19f443 2571b1a46
Author: Open vSwitch CI <ovs-ci>
Date:   Tue Jan 25 19:34:45 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    2571b1a464 ofproto-dpif: Fix issue with non-reversible actions on a patch ports.

commit 60b19f443cd2575f559aa0df22535d3279ba5438
Merge: 349d68767 07a115f7d
Author: Open vSwitch CI <ovs-ci>
Date:   Fri Jan 21 15:49:35 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    07a115f7d9 ovs-monitor-ipsec: Fix generated strongSwan ipsec.conf for IPv6.

commit 349d6876731ca5339cfb8dd67d0f3a739d1c55de
Merge: e370e283c f2ee013f7
Author: Open vSwitch CI <ovs-ci>
Date:   Wed Jan 19 21:49:23 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    f2ee013f73 datapath-windows: Pickup Ct tuple as CT lookup key in function OvsCtSetupLookupCtx

commit e370e283cf9c5f1d6ffec2f41752f470daf830a6
Merge: c9297f5ef bd8ebcd10
Author: Open vSwitch CI <ovs-ci>
Date:   Tue Jan 18 08:49:13 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    bd8ebcd10c Documentation: Fix Rx/Tx queue configuration section.

commit c9297f5ef7be51b87cb6b9148679da68c93c29b5
Merge: edae801e0 29936a853
Author: Open vSwitch CI <ovs-ci>
Date:   Mon Jan 17 10:58:43 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    29936a853f ofproto-dpif: Fix memory leak in dpif/show-dp-features appctl.

commit edae801e0036dc7021289dc4f7a26031363dcd17
Merge: 6ad0375ff ba7fffb83
Author: Open vSwitch CI <ovs-ci>
Date:   Thu Jan 13 14:59:57 2022 -0500

    Merging upstream branch-2.16
    
    Commit list:
    ba7fffb832 dpif-netdev: Improve loading of packet data for undersized packets.

commit 6ad0375ff540e41bdecb376634492f14e36143a7
Merge: 07b9bf085 2595b7b3d
Author: Open vSwitch CI <ovs-ci>
Date:   Fri Dec 17 23:54:42 2021 -0500

    Merging upstream branch-2.16
    
    Commit list:
    2595b7b3d1 Prepare for 2.16.3.
    6caaae525c Set release date for 2.16.2.
    443e3657d7 ofproto-dpif-xlate: Snoop ingress packets and update neigh cache if needed.
    75d2ef9a60 tnl-neigh-cache: Do not refresh the entry while revalidating.
    5d88836566 tnl-neigh-cache: Read/write expires atomically.
    fb42c99c15 dpif-netdev: Improve handling of IP/TCP in avx512 mfex.

commit 07b9bf085ab7144c576570c6a48fe42a44d19aca
Merge: 8708b5515 f42c48444
Author: Open vSwitch CI <ovs-ci>
Date:   Thu Dec 9 12:19:19 2021 -0500

    Merging upstream branch-2.16
    
    Commit list:
    f42c484445 compat: handle NF_REPEAT error on nf_conntrack_in.

commit 8708b5515274b6e02abe0b9b6c45a5b1f2623c8b
Merge: e90e06a81 3e527f21c
Author: Open vSwitch CI <ovs-ci>
Date:   Mon Dec 6 12:09:09 2021 -0500

    Merging upstream branch-2.16
    
    Commit list:
    3e527f21cf flow: Consider dataofs when parsing TCP packets.
    b537e049ad tests/flowgen: Fix packet data endianness.
    35244b4980 ofproto: Fix resource usage explosion due to removal of large number of flows.
    a201297639 ofproto: Fix resource usage explosion while processing bundled FLOW_MOD.
    cd0133402c tests/flowgen: Fix length field of 802.2 data link header.
    2d65b8ffd2 ovs-lib: Backup and remove existing DB when joining cluster.
    ab01177637 docs/dpdk: Fix install doc.
    38a2129524 ovs-save: Save igmp flows in ofp_parse syntax.
    dc77857ce2 faq: Update OVS/DPDK version table for OVS 2.13/2.14.