Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/jcpunk/pam_krb5/pam_krb5.git/plain/pam_krb5.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jcpunk/pam_krb5/srpm-builds/03541745/pam_krb5-4.11-1.fc35.src.rpm Description: A PAM module for kerberos auth Fedora Account System Username: jcpunk The previous pam_krb5 went end of life / unsupported. This is not the Kerberos PAM module maintained on Sourceforge and used on Red Hat systems. It is an independent implementation that, if it ever shared any common code, diverged long ago. It supports some features that the Sourceforge module does not (particularly around authorization), and does not support some options (particularly ones not directly related to Kerberos) that it does. It has been in use on Debian style systems for well over a decade.
Specified URLs are not working anymore. Please fix them to working links, makes review possible only by hand. ERROR: 'Error HTTP Error 404: Not Found downloading https://download.copr.fedorainfracloud.org/results/jcpunk/pam_krb5/srpm-builds/03541745/pam_krb5-4.11-1.fc35.src.rpm' Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/jcpunk/pam_krb5/pam_krb5.git/plain/pam_krb5.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jcpunk/pam_krb5/fedora-36-x86_64/03541745-pam_krb5/pam_krb5-4.11-1.fc36.src.rpm
Taking the review. pam_krb5-4.11-1.fc37.x86_64.rpm/usr/lib64/security/pam_krb5.la I am pretty sure .la file should not be packaged, please remove it from installed directory. I think the cleanup should me modified to: # cleanup rm -f %{buildroot}%{_pam_libdir}/security/*.la Note: rpm -E '%_mandir' and rpm -E '%_pam_libdir' both start already with slash. The leading slash in %files it not necessary.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain any libtool archives (.la) Note: pam_krb5 : /usr/lib64/security/pam_krb5.la See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/pam_krb5 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names Comment: it is intended as replacement of original pam_krb5, with higher version. It seems okay - License tag should contain also BSD ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "FSF All Permissive License", "X11 License FSF All Permissive License BSD 3-Clause License GNU General Public License, Version 3 GNU General Public License, Version 2", "BSD 3-Clause License", "BSD 3-Clause License [generated file]", "Unknown or generated", "FSF Unlimited License (with License Retention) [generated file]", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "X11 License [generated file]", "GNU General Public License v2.0 or later", "MIT License", "ISC License", "FSF Unlimited License (with License Retention)", "FSF Unlimited License (with License Retention) GNU General Public License, Version 2", "*No copyright* MIT License". 29 files have unknown license. Detailed output of licensecheck in /home/pihhan/fedora/review/2057594-pam_krb5/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/security [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. Should Require: pam to ensure /usr/lib(64)/security is owned by it. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- pam_krb5: /usr/lib64/security/pam_krb5.so Source checksums ---------------- https://github.com/rra/pam-krb5/archive/refs/tags/upstream/4.11.tar.gz : CHECKSUM(SHA256) this package : 5ddcd5652ff95627504fbf1d3c22d9b94c033e1e5a7b0d8c7e77602d6720675a CHECKSUM(SHA256) upstream package : 5ddcd5652ff95627504fbf1d3c22d9b94c033e1e5a7b0d8c7e77602d6720675a Requires -------- pam_krb5 (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcom_err.so.2()(64bit) libk5crypto.so.3()(64bit) libkrb5.so.3()(64bit) libkrb5.so.3(krb5_3_MIT)(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpam.so.0(LIBPAM_EXTENSION_1.0)(64bit) libpam.so.0(LIBPAM_MODUTIL_1.0)(64bit) rtld(GNU_HASH) pam_krb5-debuginfo (rpmlib, GLIBC filtered): pam_krb5-debugsource (rpmlib, GLIBC filtered): Provides -------- pam_krb5: pam_krb5 pam_krb5(x86-64) pam_krb5-debuginfo: debuginfo(build-id) pam_krb5-debuginfo pam_krb5-debuginfo(x86-64) pam_krb5-debugsource: pam_krb5-debugsource pam_krb5-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2057594 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: SugarActivity, R, Haskell, fonts, Perl, PHP, Ocaml, Java, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
I would recommend also including %name in url, it makes nice archives: Source0: %{url}/archive/refs/tags/upstream/%{name}-%{version}.tar.gz
I think I got most of the issues addressed.... Does this look better? Spec URL: https://download.copr.fedorainfracloud.org/results/jcpunk/pam_krb5/fedora-36-x86_64/04355794-pam_krb5/pam_krb5.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jcpunk/pam_krb5/fedora-36-x86_64/04355794-pam_krb5/pam_krb5-4.11-1.fc36.src.rpm
Sorry for the delay, it seems good now. Passing review!
Created attachment 1889634 [details] licensecheck
Package is now in repositories, closing review.