Bug 205878 - Review Request: arj - Archiver for .arj files
Summary: Review Request: arj - Archiver for .arj files
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-09-09 11:47 UTC by Hans de Goede
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-10 05:29:04 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Hans de Goede 2006-09-09 11:47:41 UTC
Spec URL: http://people.atrpms.net/~hdegoede/arj.spec
SRPM URL: http://people.atrpms.net/~hdegoede/arj-3.10.22-1.src.rpm
Description:
This package is an open source version of the arj archiver.  This
version has been created with the intent to preserve maximum
compatibility and retain the feature set of original ARJ archiver as
provided by ARJ Software, Inc.

Comment 1 Jason Tibbitts 2006-09-09 16:09:32 UTC
This looks quick and simple.  The only thing I wonder is whether it might be
useful to package up some bits so that the desktops can handle these files.  It
looks like KDE is already set up to at least recognize these files.

* source files match upstream:
   48d2275b8a8e6e5adaead8916d008fd3  arj_3.10.22-2.diff.gz
   f263bf3cf6d42a8b7e85b4fb514336d3  arj-3.10.22.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   arjcrypt.so()(64bit)
   config(arj) = 3.10.22-1.fc6
   unarj = 3.10.22-1.fc6
   arj = 3.10.22-1.fc6
  =
   /bin/sh
   config(arj) = 3.10.22-1.fc6
* %check is not present; no test suite upstream.
* no shared libraries are added to the regular linker search paths.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.

APPROVED

Comment 2 Hans de Goede 2006-09-10 05:29:04 UTC
Thanks!

Imported and build, closing.



Note You need to log in before you can comment on or make changes to this bug.