Spec URL: https://pagure.io/skanpage_rpm/raw/main/f/skanpage.spec SRPM URL: https://pagure.io/skanpage_rpm/raw/main/f/skanpage-1.0-1.fc35.src.rpm Description: Skanpage is a multi-page scanning application built using the libksane library and a QML interface. It supports saving to image and PDF files. Fedora Account System Username: thunderbirdtr
I am not a packager, but thought you would like to see this: rpmlint skanpage-1.0-1.fc35.src.rpm skanpage.src: W: invalid-license CC0-1.0 skanpage.src: E: description-line-too-long Skanpage is a simple scanning application designed for multi-page scanning and saving of documents and images. > License: GPLv3 and GPLv2 and CC0-1.0 and BSD This should be accompanied by a comment explaining which parts are subject to which licences. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios
License break down added. And description part handled.
I have a sponsor, so I am taking this review. :-) If you update the spec and srpm references, I'll start.
Oh, I see it's updated... The spec file is not matching the SRPM specfile. (rpmlint fails on both the RPM and the SRPM because of this.) The warning, "W: invalid-license CC0-1.0" seems to want "CC0" instead. But perhaps your designation is more accurate anyway. There are also minor differences in org.kde.skanpage.appdata.xml between upstream and the SRPM. I believe these are minor, so as long as the SRPM is updated to the current spec file, PACKAGE APPROVED. Output of rpmlint manually run after fedora-review: $ rpmlint /home/garry/2059001-skanpage/results/skanpage-1.0-1.fc37.src.rpm ======================================================================== rpmlint session starts ======================================================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 skanpage.src: W: invalid-license CC0-1.0 skanpage.src: E: description-line-too-long Skanpage is a simple scanning application designed for multi-page scanning and saving of documents and images. ========================================= 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.1 s ======================================== $ rpmlint /home/garry/2059001-skanpage/results/skanpage-1.0-1.fc37.x86_64.rpm ======================================================================== rpmlint session starts ======================================================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 skanpage.x86_64: W: no-manual-page-for-binary skanpage skanpage.x86_64: W: invalid-license CC0-1.0 skanpage.x86_64: E: description-line-too-long Skanpage is a simple scanning application designed for multi-page scanning and saving of documents and images. ========================================= 1 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 2.2 s ======================================== $ Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/garry/2059001-skanpage/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Creative Commons CC0 1.0", "*No copyright* BSD 2-Clause License", "*No copyright* GNU General Public License, Version 2", "Unknown or generated", "Creative Commons CC0 1.0", "BSD 2-Clause License", "GNU General Public License, Version 2", "GNU General Public License, Version 3", "*No copyright* GNU General Public License, Version 3". 6 files have unknown license. Detailed output of licensecheck in /home/garry/2059001-skanpage/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/scalable/apps [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://invent.kde.org/utilities/skanpage/-/archive/1.0/skanpage-1.0.tar.gz : CHECKSUM(SHA256) this package : f7bd4849a3f41816f6d79e5ade5d5a4c9a13a144dfd082b8168bf18eb1fd355c CHECKSUM(SHA256) upstream package : 3cd8d6d2dc406cd1913cbe51081bf69d8ba89249baa8d85a6d889e59e133fda9 diff -r also reports differences Requires -------- skanpage (rpmlib, GLIBC filtered): kf5-kirigami2 libKF5ConfigCore.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5Crash.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5Sane.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) qt5-qtquickcontrols2 rtld(GNU_HASH) skanpage-debuginfo (rpmlib, GLIBC filtered): skanpage-debugsource (rpmlib, GLIBC filtered): Provides -------- skanpage: application() application(org.kde.skanpage.desktop) metainfo() metainfo(org.kde.skanpage.appdata.xml) skanpage skanpage(x86-64) skanpage-debuginfo: debuginfo(build-id) skanpage-debuginfo skanpage-debuginfo(x86-64) skanpage-debugsource: skanpage-debugsource skanpage-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/garry/2059001-skanpage/srpm/skanpage.spec 2022-03-12 22:39:42.375612682 -0500 +++ /home/garry/2059001-skanpage/srpm-unpacked/skanpage.spec 2022-02-27 12:31:27.000000000 -0500 @@ -4,6 +4,5 @@ Version: 1.0 Release: 1%{?dist} -Summary: Utility to scan images and multi-page documents -# For a breakdown of the licensing, see PACKAGE-LICENSING +Summary: KDE Plasma scanning application License: GPLv3 and GPLv2 and CC0-1.0 and BSD @@ -41,7 +40,5 @@ %description -Skanpage is a multi-page scanning application built -using the libksane library and a QML interface. -It supports saving to image and PDF files. +Skanpage is a simple scanning application designed for multi-page scanning and saving of documents and images. %prep Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2059001 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Ocaml, fonts, Python, Perl, Java, SugarActivity, Haskell, R, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://pagure.io/skanpage_rpm/raw/main/f/skanpage-1.0-1.fc36.src.rpm SRPM is done.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/skanpage