Bug 2059502 - perl-Crypt-SMIME-0.28-2.fc37 FTBFS: Failed test 'No extra files that aren't in MANIFEST'
Summary: perl-Crypt-SMIME-0.28-2.fc37 FTBFS: Failed test 'No extra files that aren't i...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-Crypt-SMIME
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F37FTBFS
TreeView+ depends on / blocked
 
Reported: 2022-03-01 08:28 UTC by Petr Pisar
Modified: 2022-03-29 00:16 UTC (History)
4 users (show)

Fixed In Version: perl-Crypt-SMIME-0.28-3.fc37 perl-Crypt-SMIME-0.28-4.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-29 00:16:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Petr Pisar 2022-03-01 08:28:09 UTC
perl-Crypt-SMIME-0.28-2.fc37 fails to build for me locally in F37 because a test fails:

t/boilerplate.t ....... ok

    #   Failed test 'No extra files that aren't in MANIFEST'
    #   at t/manifest.t line 29.
    # Not in MANIFEST: .package_note-perl-Crypt-SMIME-0.28-2.fc37.x86_64.ld
    # Looks like you failed 1 test of 1.

#   Failed test 'extra files'
#   at t/manifest.t line 32.
# Looks like you failed 1 test of 2.
t/manifest.t .......... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests 

I have package-notes-srpm-macros-0.4-14.fc36.noarch and perl-libs-5.34.0-485.fc36.x86_64. We will probably need to clean up the file in %check section.

Comment 1 Petr Pisar 2022-03-01 08:29:50 UTC
It fails in Koschei too since <https://koschei.fedoraproject.org/build/11910122>. Upgrade of package-notes-srpm-macros from 0.4-3.fc36 to 0.4-11.fc36 looks suspicious.

Comment 2 Xavier Bachelot 2022-03-01 16:04:07 UTC
This fixes the build. Is that what you had in mind ?
'''
diff --git a/perl-Crypt-SMIME.spec b/perl-Crypt-SMIME.spec
index dfffa89..d1daf08 100644
--- a/perl-Crypt-SMIME.spec
+++ b/perl-Crypt-SMIME.spec
@@ -61,6 +61,7 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
 %{_fixperms} $RPM_BUILD_ROOT/*
 
 %check
+rm -f .package_note-%{name}-%{version}-%{release}.%{_arch}.ld
 make test
 
 %files
'''

Comment 3 Paul Howarth 2022-03-01 16:22:31 UTC
Alternative fix, using similar approach to the one already used to ignore cruft from debuginfo generation:

diff --git a/perl-Crypt-SMIME.spec b/perl-Crypt-SMIME.spec
index dfffa89..3d9cb56 100644
--- a/perl-Crypt-SMIME.spec
+++ b/perl-Crypt-SMIME.spec
@@ -46,6 +46,8 @@ verify, encrypt and decrypt messages. It requires libcrypto
 # As part of the rpm process we generate some .list files which
 # then cause t/manifest.t to fail.
 echo '\.list$' >> MANIFEST.SKIP
+# Similarly for .package_note files
+echo '^\.package_note-' >> MANIFEST.SKIP
 
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"

This issue was caused by this commit:
https://src.fedoraproject.org/rpms/package-notes/c/b7381d

Comment 4 Petr Pisar 2022-03-02 08:11:22 UTC
Yeah. Something like that. I asked package-notes to resolve it on their side (bug #2059858).

Comment 5 Fedora Update System 2022-03-18 08:34:23 UTC
FEDORA-2022-cb9b8847e5 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-cb9b8847e5

Comment 6 Fedora Update System 2022-03-18 15:53:42 UTC
FEDORA-2022-cb9b8847e5 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-cb9b8847e5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-cb9b8847e5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2022-03-23 16:51:10 UTC
FEDORA-2022-cb9b8847e5 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-cb9b8847e5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-cb9b8847e5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-03-29 00:16:50 UTC
FEDORA-2022-cb9b8847e5 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.