1. Please describe the problem: After update from 5.16.10 to 5.16.11 s2idle suspend stopped working on my Dell G15 5510 laptop. Regression is bisected. Link for kernel bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215641 dmesg output and bisect results are there 2. What is the Version-Release number of the kernel: 5.16.11-200.fc25.x86_64 3. Did it work previously in Fedora? If so, what kernel version did the issue *first* appear? Old kernels are available for download at https://koji.fedoraproject.org/koji/packageinfo?packageID=8 : 5.16.10-200.fc35.x86_64
Hmm, will have to see what to do about that, the patch that broke it is the patch that fixed suspend on a very large number of laptops, though it seems to have broken suspend on a couple of very new ones.
(In reply to Justin M. Forbes from comment #1) > Hmm, will have to see what to do about that, the patch that broke it is the > patch that fixed suspend on a very large number of laptops, though it seems > to have broken suspend on a couple of very new ones. Justin, what patch do you mean with "the patch that broke it" ? The patch pointed to in the kernel bugzilla: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=42fed57046fc74586d7058bd51a1c10ac9c690cb Only touches: drivers/phy/broadcom/phy-brcm-usb.c which only gets build when CONFIG_PHY_BRCM_USB is set and in e.g. /boot/config-5.17.0-0.rc5.102.fc36.x86_64 that is not set.
(In reply to Hans de Goede from comment #2) > Justin, what patch do you mean with "the patch that broke it" ? The patch > pointed to in the kernel bugzilla: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/ > ?id=42fed57046fc74586d7058bd51a1c10ac9c690cb > > Only touches: drivers/phy/broadcom/phy-brcm-usb.c which only gets build when > CONFIG_PHY_BRCM_USB is set and in e.g. > /boot/config-5.17.0-0.rc5.102.fc36.x86_64 that is not set. I discussed this by email with Justin and Justin was referring to the "ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE" in comment 1. As I already mentioned in the kernel bugzilla, please redo your git bisect since the commit you originally found: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=42fed57046fc74586d7058bd51a1c10ac9c690cb really cannot be the cause of this.
Note the patch Justin is talking about was merged into 5.16.10 and you indicate that 5.16.10 worked fine and that 5.16.11 is broken for you, a possible culprit for the brokenness in 5.16.11 is the "ACPI: PM: Revert "Only mark EC GPE for wakeup on Intel systems"" patch: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.16.y&id=0c430ff95116c4a635e651d9be9e4e8e1163bc5d
I already commented on kernel bugzilla that I have redone bisect test and could not reproduce the issue. It seems that the first false positive result is related to different issue I mentioned (and uploaded dmesg log) there.
(In reply to The Source from comment #5) > I already commented on kernel bugzilla that I have redone bisect test and > could not reproduce the issue. It seems that the first false positive result > is related to different issue I mentioned (and uploaded dmesg log) there. Right, I took a quick look and that seems fw-loader related, assuming the backtrace is always the same ? But I did not see any recent fw-loader changes, so not sure what to make of this.
As mentioned in the bugzilla.kernel.org bug mirroring this one: Can you please see if you are still seeing issues when not using the nvidia binary driver?
I'm currently at 5.16.15 and don't seem to have any issues. The last one was likely caused by nvidia-powerd + nvidia driver. I disabled nvidia-powerd and instabilities are gone. ext4 crash is also not reproducible anymore.
Ok, so I guess this bug and the bugzilla.kernel.org bug can be closed now?