Bug 2059964 - python-promise fails to build with pytest 7
Summary: python-promise fails to build with pytest 7
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-promise
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabian Affolter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTEST7
TreeView+ depends on / blocked
 
Reported: 2022-03-02 12:12 UTC by Miro Hrončok
Modified: 2022-03-04 09:28 UTC (History)
1 user (show)

Fixed In Version: python-promise-2.3.0-9.fc37
Clone Of:
Environment:
Last Closed: 2022-03-04 09:28:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github syrusakbary promise pull 96 0 None open Fix tests for pytest 7.0 compatibility 2022-03-02 12:12:18 UTC

Description Miro Hrončok 2022-03-02 12:12:05 UTC
In this copr repo, I have updated pytest to 7.0.1:

https://copr.fedorainfracloud.org/coprs/churchyard/pytest-7/

Based on this PR:

https://src.fedoraproject.org/rpms/pytest/pull-request/25

I'd like to update pytest to 7 in Fedora 37, but python-promise 2.3.0-8 fails to build.

https://copr.fedorainfracloud.org/coprs/churchyard/pytest-7/package/python-promise/


=================================== FAILURES ===================================
____________________ test_thrown_exceptions_have_stacktrace ____________________

    def test_thrown_exceptions_have_stacktrace():
        def throws(v):
            assert False
    
        p3 = Promise.resolve("a").then(throws)
        with raises(AssertionError) as assert_exc:
            p3.get()
    
>       assert assert_exc.traceback[-1].path.strpath == __file__
E       AttributeError: 'PosixPath' object has no attribute 'strpath'

tests/test_extra.py:116: AttributeError
__________________ test_thrown_exceptions_preserve_stacktrace __________________

    def test_thrown_exceptions_preserve_stacktrace():
        def throws(v):
            assert False
    
        def after_throws(v):
            pass
    
        p3 = Promise.resolve("a").then(throws).then(after_throws)
        with raises(AssertionError) as assert_exc:
            p3.get()
    
>       assert assert_exc.traceback[-1].path.strpath == __file__
E       AttributeError: 'PosixPath' object has no attribute 'strpath'

tests/test_extra.py:130: AttributeError


A fix has been proposed upstream in https://github.com/syrusakbary/promise/pull/96


There are several packages affected by this update, so I'd very much appreciate it if you could backport the fix.

Thanks!

Comment 1 Fedora Update System 2022-03-04 09:26:13 UTC
FEDORA-2022-1abcee7ee8 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1abcee7ee8

Comment 2 Fedora Update System 2022-03-04 09:28:23 UTC
FEDORA-2022-1abcee7ee8 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.