Bug 2060007 - No rule to make target 'docker-push' when building the SRO bundle
Summary: No rule to make target 'docker-push' when building the SRO bundle
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Special Resource Operator
Version: 4.11
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.10.z
Assignee: Brett Thurber
QA Contact: Udi Kalifon
URL:
Whiteboard:
Depends On: 2066923
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-02 14:07 UTC by Udi Kalifon
Modified: 2022-04-08 05:04 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2066923 (view as bug list)
Environment:
Last Closed: 2022-04-08 05:04:20 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift special-resource-operator pull 122 0 None open Bug 2060007: Makefile fixes for: no rule 'docker-push' 2022-03-22 19:25:11 UTC
Red Hat Product Errata RHSA-2022:1162 0 None None None 2022-04-08 05:04:39 UTC

Description Udi Kalifon 2022-03-02 14:07:10 UTC
Description of problem:
The Makefile in branch release-4.10 has some targets with "podman" hard-coded and some targets with "docker" hard-coded. It means that you would always fail unless you have the two commands symlinked to each other. We need to parameterize the container command.


Version-Release number of selected component (if applicable):
release-4.10


How reproducible:
100%


Steps to Reproduce:
1) Get the SRO repo:
git clone https://github.com/openshift/special-resource-operator
cd special-resource-operator
git checkout release-4.10

2) Build and push:
podman login -u <quay_user> quay.io
IMAGE_TAG_BASE=quay.io/<quay_user>/special-resource-operator IMG=quay.io/<quay_user>/special-resource-operator make local-image-build local-image-push bundle bundle-build bundle-push

3) Create the namespace and run the bundle:
apiVersion: v1
kind: Namespace
metadata:
  name: openshift-special-resource-operator

oc project openshift-special-resource-operator
operator-sdk run bundle quay.io/<quay_user>/special-resource-operator-bundle:v0.0.1


Actual results:
I only have podman, so I get: No rule to make target 'docker-push' 


Expected results:
Use the right container command consistently


Additional info:
Proposed fix: https://github.com/openshift/special-resource-operator/pull/122

Comment 1 Udi Kalifon 2022-03-03 07:57:03 UTC
This bug is for the 4.10 branch only, although it is opened on 4.11. Don't merge this into 4.11.

Comment 7 errata-xmlrpc 2022-04-08 05:04:20 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.10.8 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1162


Note You need to log in before you can comment on or make changes to this bug.