Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2060007

Summary:	No rule to make target 'docker-push' when building the SRO bundle
Product:	OpenShift Container Platform	Reporter:	Udi Kalifon <ukalifon>
Component:	Special Resource Operator	Assignee:	Brett Thurber <bthurber>
Status:	CLOSED ERRATA	QA Contact:	Udi Kalifon <ukalifon>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.11	CC:	aos-bugs, quba
Target Milestone:	---
Target Release:	4.10.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2066923 (view as bug list)		Environment:
Last Closed:	2022-04-08 05:04:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2066923
Bug Blocks:

Description Udi Kalifon 2022-03-02 14:07:10 UTC

Description of problem:
The Makefile in branch release-4.10 has some targets with "podman" hard-coded and some targets with "docker" hard-coded. It means that you would always fail unless you have the two commands symlinked to each other. We need to parameterize the container command.


Version-Release number of selected component (if applicable):
release-4.10


How reproducible:
100%


Steps to Reproduce:
1) Get the SRO repo:
git clone https://github.com/openshift/special-resource-operator
cd special-resource-operator
git checkout release-4.10

2) Build and push:
podman login -u <quay_user> quay.io
IMAGE_TAG_BASE=quay.io/<quay_user>/special-resource-operator IMG=quay.io/<quay_user>/special-resource-operator make local-image-build local-image-push bundle bundle-build bundle-push

3) Create the namespace and run the bundle:
apiVersion: v1
kind: Namespace
metadata:
  name: openshift-special-resource-operator

oc project openshift-special-resource-operator
operator-sdk run bundle quay.io/<quay_user>/special-resource-operator-bundle:v0.0.1


Actual results:
I only have podman, so I get: No rule to make target 'docker-push' 


Expected results:
Use the right container command consistently


Additional info:
Proposed fix: https://github.com/openshift/special-resource-operator/pull/122

Comment 1 Udi Kalifon 2022-03-03 07:57:03 UTC

This bug is for the 4.10 branch only, although it is opened on 4.11. Don't merge this into 4.11.

Comment 7 errata-xmlrpc 2022-04-08 05:04:20 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.10.8 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1162