Bug 2060087 - python-glymur test failures on s390x
Summary: python-glymur test failures on s390x
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-glymur
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ben Beasley
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 2060033
TreeView+ depends on / blocked
 
Reported: 2022-03-02 16:53 UTC by Ben Beasley
Modified: 2022-04-02 01:56 UTC (History)
2 users (show)

Fixed In Version: python-glymur-0.9.9-1.fc37 python-glymur-0.9.9-1.fc36 python-glymur-0.9.9-1.fc35 python-glymur-0.9.9-1.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-24 15:41:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Build log with test failure details (120.29 KB, text/plain)
2022-03-02 16:53 UTC, Ben Beasley
no flags Details

Description Ben Beasley 2022-03-02 16:53:11 UTC
Created attachment 1863861 [details]
Build log with test failure details

Description of problem:

Multiple tests fail on s390x.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. fedpkg scratch-build --arches s390x

Actual results:

Success, as on other architectures

Expected results:

FAILED tests/test_tiff2jp2.py::TestSuite::test_minisblack_3strip_to_2x2 - Zer...
FAILED tests/test_tiff2jp2.py::TestSuite::test_partial_last_strip - ZeroDivis...
FAILED tests/test_tiff2jp2.py::TestSuite::test_partial_strip_and_partial_tiles
FAILED tests/test_tiff2jp2.py::TestSuite::test_psnr - AssertionError: False i...
FAILED tests/test_tiff2jp2.py::TestSuiteNoScikitImage::test_rgb_stripped - Ze...
FAILED tests/test_tiff2jp2.py::TestSuiteNoScikitImage::test_rgb_stripped_bottom_of_tile_coincides_with_bottom_of_strip
FAILED tests/test_tiff2jp2.py::TestSuiteNoScikitImage::test_stripped_logging


Additional info:

See attached build log, which assumes https://src.fedoraproject.org/rpms/python-glymur/pull-request/1 has been merged.

Since s390x is the only big-endian architecture in Fedora, one can assume that endianness-related issues are a likely cause. It’s not obvious whether the problem is in glymur or in openjpeg2, although I would guess glymur is more likely.

Comment 1 Ben Beasley 2022-03-02 17:20:12 UTC
It looks like these failures are new in 0.9.7 vs. 0.9.4. They are all for the new tiff2jp2 tool.

Comment 2 Ben Beasley 2022-03-20 16:10:24 UTC
I’ve figured out what’s going on here: https://github.com/quintusdias/glymur/issues/545

Comment 3 Ben Beasley 2022-03-21 12:56:44 UTC
Upstream has promised to work on this. Most of the tests that fail are due to a real bug that could affect TIFF images with RowsPerStrip>65535 on any platform, but is much worse on big-endian platforms. The “psnr” test fails for a different reason that I haven’t looked into yet. If upstream doesn’t fix it together with the main bug, I’ll report it separately.

Given all that, I think it’s OK to go ahead and skip the failing tests on s390x and package 0.9.8 to resolve bug 2060033 and bug 2062941. I’ll update https://src.fedoraproject.org/rpms/python-glymur/pull-request/1 to do that.

Comment 4 Vanessa Christopher 2022-03-22 15:02:14 UTC
oh I see this is assigned to me?

Comment 5 Ben Beasley 2022-03-22 15:35:16 UTC
As the one who requested the dist-git repo, you’re the package owner / main admin, so you’re the default bug assignee, and bugfixes/updates are generally up to you unless someone else notices and steps up.

That said, I think I meant to assign this to myself when I changed the status to ASSIGNED. I’ve merged [1] with a workaround to skip the failing tests, and for now this issue is in upstream’s hands to fix. I’m subscribed to the upstream bug[2], so I should notice when upstream offers a fix and follow up here. As the main admin for this package, you might want to subscribe to the upstream bug, too.

[1] https://src.fedoraproject.org/rpms/python-glymur/pull-request/2
[2] https://github.com/quintusdias/glymur/issues/545

Comment 6 Vanessa Christopher 2022-03-23 12:18:59 UTC
(In reply to Ben Beasley from comment #5)
> As the one who requested the dist-git repo, you’re the package owner / main
> admin, so you’re the default bug assignee, and bugfixes/updates are
> generally up to you unless someone else notices and steps up.
> 
> That said, I think I meant to assign this to myself when I changed the
> status to ASSIGNED. I’ve merged [1] with a workaround to skip the failing
> tests, and for now this issue is in upstream’s hands to fix. I’m subscribed
> to the upstream bug[2], so I should notice when upstream offers a fix and
> follow up here. As the main admin for this package, you might want to
> subscribe to the upstream bug, too.
> 
> [1] https://src.fedoraproject.org/rpms/python-glymur/pull-request/2
> [2] https://github.com/quintusdias/glymur/issues/545

Alright, thank you.

Comment 7 Fedora Update System 2022-03-24 15:38:59 UTC
FEDORA-2022-63d37b251a has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-63d37b251a

Comment 8 Fedora Update System 2022-03-24 15:41:40 UTC
FEDORA-2022-63d37b251a has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-03-24 16:30:19 UTC
FEDORA-2022-43a14f9ff4 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-43a14f9ff4

Comment 10 Fedora Update System 2022-03-24 16:43:17 UTC
FEDORA-2022-4d2547f6fc has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4d2547f6fc

Comment 11 Fedora Update System 2022-03-24 17:00:08 UTC
FEDORA-2022-bc8c250ccd has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bc8c250ccd

Comment 12 Fedora Update System 2022-03-24 18:08:07 UTC
FEDORA-2022-43a14f9ff4 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-43a14f9ff4`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-43a14f9ff4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-03-25 22:55:07 UTC
FEDORA-2022-bc8c250ccd has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-bc8c250ccd`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-bc8c250ccd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-03-25 23:25:17 UTC
FEDORA-2022-4d2547f6fc has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-4d2547f6fc`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4d2547f6fc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-03-28 00:16:57 UTC
FEDORA-2022-43a14f9ff4 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-04-02 01:54:04 UTC
FEDORA-2022-4d2547f6fc has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2022-04-02 01:56:13 UTC
FEDORA-2022-bc8c250ccd has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.