Bug 2060218 - Review Request: python-socksio - Client-side sans-I/O SOCKS proxy implementation
Summary: Review Request: python-socksio - Client-side sans-I/O SOCKS proxy implementation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2037405
TreeView+ depends on / blocked
 
Reported: 2022-03-03 01:17 UTC by Carl George 🤠
Modified: 2022-03-04 18:52 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-03 19:40:06 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Carl George 🤠 2022-03-03 01:17:16 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/03595717-python-socksio/python-socksio.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/03595717-python-socksio/python-socksio-1.0.0-1.fc37.src.rpm

Description:
Client-side sans-I/O SOCKS proxy implementation. Supports SOCKS4, SOCKS4A, and
SOCKS5.  socksio is a sans-I/O library similar to h11 or h2, this means the
library itself does not handle the actual sending of the bytes through the
network, it only deals with the implementation details of the SOCKS protocols
so you can use it in any I/O library you want.

Fedora Account System Username: carlwgeorge

Comment 1 Neal Gompa 2022-03-03 01:31:46 UTC
Review notes:

[x]: Package follows Fedora Python Packaging Guidelines
[x]: Package builds and installs
[x]: No serious issues from rpmlint
[x]: License is correctly identified and installed

PACKAGE APPROVED.

Comment 2 Gwyn Ciesla 2022-03-03 15:02:17 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-socksio

Comment 3 Fedora Update System 2022-03-03 19:38:24 UTC
FEDORA-2022-cba8cebc87 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-cba8cebc87

Comment 4 Fedora Update System 2022-03-03 19:40:06 UTC
FEDORA-2022-cba8cebc87 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Miro Hrončok 2022-03-04 10:53:23 UTC
> [x]: License is correctly identified and installed

But it is not identified, only installed.

/usr/lib/python3.10/site-packages/socksio-1.0.0.dist-info/LICENSE is included in the package but not marked as license.




Also, the manual buildrequires for flit-core is redundant, it is marked as [build-system] requirement in pyproject.toml.




-> https://src.fedoraproject.org/rpms/python-socksio/pull-request/1


Note You need to log in before you can comment on or make changes to this bug.