Hide Forgot
Created attachment 1864129 [details] Patch fixing wx/lib/agw/aui/tabart.py Description of problem: There are integer issues when using the new GUI developed in GRASS-dev (upcoming GRASS GIS 8.2): (patch attempt attached) ``` File "/usr/lib64/python3.10/site-packages/wx/core.py", line 3285, in <lambda> lambda event: event.callable(*event.args, **event.kw) ) File "/home/mneteler/software/grass_main/dist.x86_64-pc-linux-gnu/gui/wxpython/wxgui.py", line 95, in show_main_gui mainframe = GMFrame(parent=None, id=wx.ID_ANY, workspace=self.workspaceFile) File "/home/mneteler/software/grass_main/dist.x86_64-pc-linux-gnu/gui/wxpython/main_window/frame.py", line 164, in __init__ self.BuildPanes() File "/home/mneteler/software/grass_main/dist.x86_64-pc-linux-gnu/gui/wxpython/main_window/frame.py", line 645, in BuildPanes self._auimgr.AddPane( File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/framemanager.py", line 4711, in AddPane return self.AddPane4(window, arg1, target) File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/framemanager.py", line 4879, in AddPane4 self.UpdateNotebook() File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/framemanager.py", line 6653, in UpdateNotebook notebook.AddPage(pane.window, title, True, pane.icon) File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 3575, in AddPage return self.InsertPage(self.GetPageCount(), page, caption, select, bitmap, disabled_bitmap, control, tooltip) File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 3653, in InsertPage self.SetSelectionToWindow(page) File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 4410, in SetSelectionToWindow self.SetSelection(idx) File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 4357, in SetSelection ctrl.MakeTabVisible(ctrl_idx, ctrl) File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 1843, in MakeTabVisible if not self.IsTabVisible(tabPage, self.GetTabOffset(), dc, win): File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 1732, in IsTabVisible self.Render(dc, wnd) File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 1687, in Render page.rect, tab_button.rect, x_extent = self._art.DrawTab(dc, wnd, page, rect, tab_button.cur_state) File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/tabart.py", line 475, in DrawTab r.SetHeight(r.GetHeight()/2) TypeError: Rect.SetHeight(): argument 1 has unexpected type 'float' ``` (and more) Version-Release number of selected component (if applicable): python3-wxpython4-4.0.7-28.fc35.x86_64 How reproducible: Compile "Main" branch of GRASS GIS https://github.com/OSGeo/grass/ Start it and also `g.gui`. Actual results: Errors below. Expected results: GUI starts. Additional info: I have attempted to prepare a patch - attached. It may need corrections but as such I was able to start the GUI.
FEDORA-2022-bc6dfba9b2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bc6dfba9b2
FEDORA-2022-8f0253fa90 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8f0253fa90
FEDORA-2022-8f0253fa90 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-8f0253fa90` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8f0253fa90 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-bc6dfba9b2 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-bc6dfba9b2` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-bc6dfba9b2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-8f0253fa90 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-bc6dfba9b2 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.