Bug 2060854 - Integer bugs in wx/lib/agw/aui/tabart.py
Summary: Integer bugs in wx/lib/agw/aui/tabart.py
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-wxpython4
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Scott Talbert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-04 11:36 UTC by markusN
Modified: 2022-03-26 15:18 UTC (History)
1 user (show)

Fixed In Version: python-wxpython4-4.0.7-29.fc35 python-wxpython4-4.0.7-29.fc36
Doc Type: ---
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-18 20:06:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch fixing wx/lib/agw/aui/tabart.py (2.34 KB, patch)
2022-03-04 11:36 UTC, markusN
no flags Details | Diff

Description markusN 2022-03-04 11:36:08 UTC
Created attachment 1864129 [details]
Patch fixing wx/lib/agw/aui/tabart.py

Description of problem:

There are integer issues when using the new GUI developed in GRASS-dev (upcoming GRASS GIS 8.2):

(patch attempt attached)

```
  File "/usr/lib64/python3.10/site-packages/wx/core.py", line 3285, in <lambda>
    lambda event: event.callable(*event.args, **event.kw) )
  File "/home/mneteler/software/grass_main/dist.x86_64-pc-linux-gnu/gui/wxpython/wxgui.py", line 95, in show_main_gui
    mainframe = GMFrame(parent=None, id=wx.ID_ANY, workspace=self.workspaceFile)
  File "/home/mneteler/software/grass_main/dist.x86_64-pc-linux-gnu/gui/wxpython/main_window/frame.py", line 164, in __init__
    self.BuildPanes()
  File "/home/mneteler/software/grass_main/dist.x86_64-pc-linux-gnu/gui/wxpython/main_window/frame.py", line 645, in BuildPanes
    self._auimgr.AddPane(
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/framemanager.py", line 4711, in AddPane
    return self.AddPane4(window, arg1, target)
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/framemanager.py", line 4879, in AddPane4
    self.UpdateNotebook()
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/framemanager.py", line 6653, in UpdateNotebook
    notebook.AddPage(pane.window, title, True, pane.icon)
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 3575, in AddPage
    return self.InsertPage(self.GetPageCount(), page, caption, select, bitmap, disabled_bitmap, control, tooltip)
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 3653, in InsertPage
    self.SetSelectionToWindow(page)
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 4410, in SetSelectionToWindow
    self.SetSelection(idx)
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 4357, in SetSelection
    ctrl.MakeTabVisible(ctrl_idx, ctrl)
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 1843, in MakeTabVisible
    if not self.IsTabVisible(tabPage, self.GetTabOffset(), dc, win):
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 1732, in IsTabVisible
    self.Render(dc, wnd)
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/auibook.py", line 1687, in Render
    page.rect, tab_button.rect, x_extent = self._art.DrawTab(dc, wnd, page, rect, tab_button.cur_state)
  File "/usr/lib64/python3.10/site-packages/wx/lib/agw/aui/tabart.py", line 475, in DrawTab
    r.SetHeight(r.GetHeight()/2)
TypeError: Rect.SetHeight(): argument 1 has unexpected type 'float'

```

(and more)

Version-Release number of selected component (if applicable):
python3-wxpython4-4.0.7-28.fc35.x86_64

How reproducible:
Compile "Main" branch of GRASS GIS https://github.com/OSGeo/grass/
Start it and also `g.gui`.

Actual results:
Errors below.

Expected results:
GUI starts.

Additional info:
I have attempted to prepare a patch - attached. It may need corrections but as such I was able to start the GUI.

Comment 1 Fedora Update System 2022-03-11 02:31:04 UTC
FEDORA-2022-bc6dfba9b2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bc6dfba9b2

Comment 2 Fedora Update System 2022-03-11 04:58:38 UTC
FEDORA-2022-8f0253fa90 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8f0253fa90

Comment 3 Fedora Update System 2022-03-11 15:46:07 UTC
FEDORA-2022-8f0253fa90 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-8f0253fa90`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8f0253fa90

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2022-03-11 19:26:06 UTC
FEDORA-2022-bc6dfba9b2 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-bc6dfba9b2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-bc6dfba9b2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2022-03-18 20:06:02 UTC
FEDORA-2022-8f0253fa90 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2022-03-26 15:18:35 UTC
FEDORA-2022-bc6dfba9b2 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.