Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2061277

Summary: corosync logrotate issues
Product: Red Hat Enterprise Linux 9 Reporter: lejeczek <peljasz>
Component: selinux-policyAssignee: Zdenek Pytela <zpytela>
Status: CLOSED ERRATA QA Contact: Milos Malik <mmalik>
Severity: urgent Docs Contact:
Priority: high    
Version: CentOS StreamCC: bstinson, ccaulfie, cfeist, cluster-maint, jfriesse, jwboyer, kshawcro, lvrabec, mmalik, pgm-rhel-tools, pvlasin, ssekidde, zpytela
Target Milestone: rcKeywords: Triaged
Target Release: 9.0Flags: pm-rhel: mirror+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: selinux-policy-34.1.29-1.el9_0 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 2067501 (view as bug list) Environment:
Last Closed: 2022-05-17 15:50:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2067501    
Deadline: 2022-03-22   

Description lejeczek 2022-03-07 08:52:22 UTC
Description of problem:

-> $ systemctl status -l logrotate.service
× logrotate.service - Rotate log files
     Loaded: loaded (/usr/lib/systemd/system/logrotate.service; static)
     Active: failed (Result: exit-code) since Mon 2022-03-07 00:00:01 GMT; 8h ago
TriggeredBy: ● logrotate.timer
       Docs: man:logrotate(8)
             man:logrotate.conf(5)
    Process: 902688 ExecStart=/usr/sbin/logrotate /etc/logrotate.conf (code=exited, status=1/FAILURE)
   Main PID: 902688 (code=exited, status=1/FAILURE)
        CPU: 32ms

Mar 07 00:00:01 whale.mine.private systemd[1]: Starting Rotate log files...
Mar 07 00:00:01 whale.mine.private logrotate[902769]: Could not initialize corosync configuration API error CS_ERR_ACCESS
Mar 07 00:00:01 whale.mine.private logrotate[902688]: error: error running non-shared postrotate script for /var/log/cluster/corosync.log of '/var/log/cluster/corosync.log '
Mar 07 00:00:01 whale.mine.private systemd[1]: logrotate.service: Main process exited, code=exited, status=1/FAILURE
Mar 07 00:00:01 whale.mine.private systemd[1]: logrotate.service: Failed with result 'exit-code'.
Mar 07 00:00:01 whale.mine.private systemd[1]: Failed to start Rotate log files.


Version-Release number of selected component (if applicable):

corosync-3.1.5-3.el9.x86_64

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Jan Friesse 2022-03-07 10:10:31 UTC
Hi,
thank you for the report. This is happening because of corosync calling corosync-cfgtool to instruct corosync reopen all log files. corosync-cfgtool is using unix socket for communication so corosync-cfgtool must have access to the socket.

The problem you see is because of enabled selinux and logrotate running using logrotate_t context which is not allowed to connect to corosync unix socket.

The setroubleshoot helps and shows solution:
setsebool -P daemons_enable_cluster_mode 1

When you enable this boolean logrotate will work.

Still investigating if this is new to RHEL 9 (logrotate using cfgtool -L is used for all corosync 3.x -> all of RHEL 8, so it shouldn't).

Comment 2 Jan Friesse 2022-03-09 09:50:29 UTC
Ok so found out major differences between RHEL 8 and 9.

1. Because of old libqb without support for logfiles reopening corosync still uses "copytruncate" method
2. logrotate in RHEL 8 is not systemd one-time service (triggered by timer) but rather crond script so potential failures are not service failures

So right now I can see two possible solutions:
1. Add rule to selinux policy which would allow running cfgtool in logrotate context
2. Make corosync to use "copytruncate" logrotate again

So I will try to reassign to selinux team and see their opinion.

Comment 3 Jan Friesse 2022-03-09 09:54:29 UTC
@selinux-policy maintainer(s):

would it be possible to add rule similar to generated by audit2allow to selinux policy?

```
module my-corosynccfgtoo 1.0;

require {
type logrotate_t;
type cluster_t;
class unix_stream_socket connectto;
}

#============= logrotate_t ==============

#!!!! This avc is allowed in the current policy
allow logrotate_t cluster_t:unix_stream_socket connectto;

```

If not possible, please reassign back to corosync (and I will change rpm to use copytruncate logrotate config file again).

Comment 8 Milos Malik 2022-03-15 14:57:20 UTC
# setsebool -P daemons_enable_cluster_mode on

Above-mentioned command can be used as workaround before the bug is fixed:

# rpm -qa selinux\*
selinux-policy-34.1.27-1.el9.noarch
selinux-policy-targeted-34.1.27-1.el9.noarch
# sesearch -s logrotate_t -t cluster_t -c unix_stream_socket -p connectto -A
allow daemon daemon:unix_stream_socket connectto; [ daemons_enable_cluster_mode ]:True
#

Comment 20 Jan Friesse 2022-03-28 10:01:34 UTC
Hi,
I've gave quick test to the updated policy and sadly it doesn't fix the problem. libqb is also mmaping/reading/writing files in /dev/shm so complete policy needed is:

```
module my-corosynccfgtoo 1.0;

require {
  type logrotate_t;
  type cluster_t;
  type cluster_tmpfs_t;
  class unix_stream_socket connectto;
  class file { map open read write };
}

#============= logrotate_t ==============

allow logrotate_t cluster_t:unix_stream_socket connectto;
allow logrotate_t cluster_tmpfs_t:file { open read write };
allow logrotate_t cluster_tmpfs_t:file map;

```

(I think "map" line could be merged with "open read write" - this is result of test-fail-audit2allow cycle with enforcing policy enabled)

Comment 21 Milos Malik 2022-03-28 10:38:01 UTC
I already discussed the following issue with @zpytela :

# matchpathcon /usr/sbin/corosync-cfgtool 
/usr/sbin/corosync-cfgtool	system_u:object_r:bin_t:s0
# ls -lZ /usr/sbin/corosync-cfgtool 
-rwxr-xr-x. 1 root root system_u:object_r:bin_t:s0 24840 Nov 25 09:22 /usr/sbin/corosync-cfgtool
#

SELinux policy defines the transition, but the transition does not happen because of incorrect label on the corosync-cfgtool program.

Comment 30 Zdenek Pytela 2022-04-05 13:22:06 UTC
*** Bug 2067501 has been marked as a duplicate of this bug. ***

Comment 32 errata-xmlrpc 2022-05-17 15:50:20 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: selinux-policy), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3918