RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2061557 - issue with libmagic and floating point exceptions
Summary: issue with libmagic and floating point exceptions
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: file
Version: 8.5
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Vincent Mihalkovič
QA Contact: Karel Volný
URL:
Whiteboard:
Depends On:
Blocks: 2164840
TreeView+ depends on / blocked
 
Reported: 2022-03-07 20:10 UTC by Paulo Andrade
Modified: 2023-05-16 11:23 UTC (History)
2 users (show)

Fixed In Version: file-5.33-22.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2164840 (view as bug list)
Environment:
Last Closed: 2023-05-16 09:12:55 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-114749 0 None None None 2022-03-07 20:17:19 UTC
Red Hat Product Errata RHBA-2023:3063 0 None None None 2023-05-16 09:12:58 UTC

Description Paulo Andrade 2022-03-07 20:10:26 UTC
User has software with floating point exceptions enabled, and when using
libmagic internals, get a floating point exception when comparing a NaN with
a number.

This is a very special case, but would force user to disable/enable exceptions
when calling libmagic functions. Or, user suggests libmagic could
disable/(re)enable exceptions.

  Sample of what happens:

"""
#include <stdio.h>
#include <math.h>
#include <fenv.h>

int feenableexcept(int);
int fedisableexcept(int);

int
main(int argc, char *argv[])
{
  union {
    int   i;
    float f;
  } u[2];
  fedisableexcept(FE_ALL_EXCEPT);
  feenableexcept(FE_INVALID);
  u[0].i = -1;  // NaN
  u[1].f = 1;
  printf("%d\n", u[0].f < u[1].f);
  //printf("%d\n", isless(u[0].f, u[1].f));
  return 0;
}
"""

$ gcc test.c -lm
$ ./a.out
Floating point exception (core dumped)

  User also sets other exceptions, but libmagic should only trigger
FE_INVALID.

  A possible pseudo patch would be to change file/softmagic.c with pseudo patch:

...
#include <math.h>
...
		case '!':
-			matched = fv != fl;
+			matched = isunordered(fv, fl) ? 1 : fv != fl;
			break;

		case '=':
-			matched = fv == fl;
+			matched = isunordered(fv, fl) ? 0 : fv == fl;
			break;

		case '>':
-			matched = fv > fl;
+			matched = isgreater(fv, fl);
			break;

		case '<':
-			matched = fv < fl;
+			matched = isless(fv, fl);
			break;
...

and as appropriate for double values.

  There should be no floating operations on infinities or division
by zero, so, the above should resolve the issue for the user. There would
be a small extra overhead, when using the macros, that resolve to
__builtin_is{less,greater,unordered}.

  The problem happens with a customer user file. User is afraid other data
files might trigger the problem in libmagic.

Comment 1 Karel Volný 2023-02-07 14:37:51 UTC
do we have a reproducer for this?

Comment 2 Paulo Andrade 2023-02-07 14:54:15 UTC
There is a sample program and input reproducer in the customer portal
support case.

It is too large to attach to bugzilla.

The problem does not happen in latest libmagic upstream as it uses a
different code path. The problem is triggered by the rhel8 version of
libmagic and the pattern in the sample file.

If you have trouble getting the data from the customer portal please
let me know.

Comment 3 Karel Volný 2023-02-07 15:54:57 UTC
(In reply to Paulo Andrade from comment #2)
> There is a sample program and input reproducer in the customer portal
> support case.
> 
> It is too large to attach to bugzilla.

ok, in that case, it'd be impractical to use it for regression testing, large blobs aren't good for git either

I guess patch review is sufficient then ...

> If you have trouble getting the data from the customer portal please
> let me know.

well, yes, I do, currently I'm getting this error:
"The credentials you provided are valid, but you do not have direct support from Red Hat."

Comment 11 errata-xmlrpc 2023-05-16 09:12:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (file bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:3063


Note You need to log in before you can comment on or make changes to this bug.