Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2061740

Summary:	[RFE][OSP17] tripleoclient hook to run validations on heat stacks after then have been created
Product:	Red Hat OpenStack	Reporter:	David Vallee Delisle <dvd>
Component:	python-tripleoclient	Assignee:	mathieu bultel <mbultel>
Status:	CLOSED WONTFIX	QA Contact:	David Rosenfeld <drosenfe>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	18.0 (Zed)	CC:	bdobreli, bshephar, cjeanner, ekuris, jhakimra, jjoyce, jpodivin, jschluet, jslagle, mbultel, mburns, pweeks, ramishra, sathlang, slinaber, smooney, tvignaud
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2028171	Environment:
Last Closed:	2024-12-12 15:48:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Vallee Delisle 2022-03-08 13:23:53 UTC

+++ This bug was initially created as a clone of Bug #2028171 +++

There's has been some situations where failing early on templates misconfiguration could help. That would be great to have some kind of hook where tripleo-validations would be called on specific validations running on the generated stacks and could trigger a hard stop on the deployment based on some conditions.

For example, we had to do something similar at some point to address some TSX change [1]. That would have been great if there was some easier ways of doing such validations.


[1] https://review.opendev.org/c/openstack/python-tripleoclient/+/791089

Comment 2 Cédric Jeanneret 2022-03-09 10:57:41 UTC

This sounds like one of those preflight checks we already have nested in tripleoclient code for the undercloud[1].

IMHO, this is tripleo specific, and should probably not involve the VF squad; Therefore, I'm moving this to DF.

Some more details are needed, but, reading the original issue, it looks like there's a need to validate the generated templates, in order to look for deprecated configurations. IIRC, this is already existing - at least, before we start the actual OC deploy, we can see a list of parameters that are set but unused. I'm wondering if we couldn't extend a bit this specific check[2] and, well, crash the deploy in some specific cases

Would that answer the need, David?

Mathieu, any thoughts from the VF point of view?

Cheers,

C.


[1] https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v1/undercloud_preflight.py
[2] https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/workflows/parameters.py#L112

Comment 3 David Vallee Delisle 2022-03-09 13:03:11 UTC

The idea behind this RFE is to call validations during the stage after the templates are generated and making the generated template datastructure available to the validation framework so it's easy to run some validations against the generated templates.

Comment 4 Bogdan Dobrelya 2022-03-09 13:12:51 UTC

Correct, then VF could act upon the given template datastructure, using pre-deploy validations stage. While encoding conditions and actions in tripleoclient would be suboptimal.

Comment 9 Red Hat Bugzilla 2025-04-12 04:25:07 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days