Bug 2062678 - Installing snapd renders XDG_DATA_DIRS invalid if using fish shell
Summary: Installing snapd renders XDG_DATA_DIRS invalid if using fish shell
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: snapd
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zygmunt Krynicki
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-10 10:47 UTC by Gergely Polonkai
Modified: 2022-03-26 15:19 UTC (History)
4 users (show)

Fixed In Version: snapd-2.54.4-1.fc37 snapd-2.54.4-1.el7 snapd-2.54.4-1.el9 snapd-2.54.4-1.fc34 snapd-2.54.4-1.fc35 snapd-2.54.4-1.el8 snapd-2.54.4-1.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-11 09:29:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1957155 0 None None None 2022-03-10 11:39:20 UTC
Launchpad 1961791 0 None None None 2022-03-10 11:40:33 UTC

Description Gergely Polonkai 2022-03-10 10:47:37 UTC
Description of problem:

Snapd’s fish configuration (/usr/share/fish/vendor_conf.d/snapd.fish) adds its own data directory (/var/lib/snapd/desktop) to the end of $XDG_DATA_DIRS using space as a separator, which makes most (all?) application using this variable not work.

Version-Release number of selected component (if applicable):

snapd-2.54.3-1.fc35.x86_64

How reproducible:

Install the snapd package and (re)start the fish shell.

Steps to Reproduce:
1. Install the snapd package
2. (re)start the fish shell

Actual results:

The value of XDG_DATA_DIRS is "ORIGINAL_VALUE /var/lib/snapd/desktop"

Expected results:

The value of XDG_DATA_DIRS is "ORIGINAL_VALUE:/var/lib/snapd/desktop"

Additional info:

Although fish indeed uses space as a separator in the PATH environment variable, XDG_DATA_DIRS should not be extended like this, but using the colon.

Comment 1 Gergely Polonkai 2022-03-10 10:55:09 UTC
Seems to be already fixed by upstream (see https://launchpad.net/snapd/+bug/1957155 which i can’t link as bugzilla says it’s unknown to it).

Comment 2 Maciek Borzecki 2022-03-10 12:10:38 UTC
I am confused. AFAICT Fedora 35 has fish 3.3, which was supposed to treat XDG_DATA_DIRS as path like thing already (actually even since fish 3.1 release). I haven't backported the patches, as Ubuntu has an old version of fish. Though looking at the upstream code https://github.com/fish-shell/fish-shell/blob/c6166f8cedf768e5ca2373ed13ab64c6681a34b2/share/config.fish the vendor config files are applied at the very end. So for XDG_DATA_DIRS to not be configured like a path it must have been set already when it reached this: https://github.com/fish-shell/fish-shell/blob/c6166f8cedf768e5ca2373ed13ab64c6681a34b2/share/config.fish#L56 (why?). I'm guessing something else, which runs before fish, must have set this variable, so it never gets switched to the 'path' mode and thus `set` no longer works in a predictable way.

Comment 3 Fedora Update System 2022-03-11 09:26:10 UTC
FEDORA-2022-a1ee445f2b has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a1ee445f2b

Comment 4 Fedora Update System 2022-03-11 09:29:39 UTC
FEDORA-2022-a1ee445f2b has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Fedora Update System 2022-03-11 09:33:28 UTC
FEDORA-2022-3f5d692439 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3f5d692439

Comment 6 Fedora Update System 2022-03-11 09:33:29 UTC
FEDORA-2022-fa0fd2e5f0 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fa0fd2e5f0

Comment 7 Fedora Update System 2022-03-11 09:33:29 UTC
FEDORA-2022-9c42c03669 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9c42c03669

Comment 8 Fedora Update System 2022-03-11 09:35:33 UTC
FEDORA-EPEL-2022-1850977bce has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-1850977bce

Comment 9 Fedora Update System 2022-03-11 09:35:34 UTC
FEDORA-EPEL-2022-6e723fda27 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-6e723fda27

Comment 10 Fedora Update System 2022-03-11 09:35:34 UTC
FEDORA-EPEL-2022-a7681d7e28 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-a7681d7e28

Comment 11 Fedora Update System 2022-03-11 14:45:50 UTC
FEDORA-EPEL-2022-6e723fda27 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-6e723fda27

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-03-11 14:47:02 UTC
FEDORA-EPEL-2022-1850977bce has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-1850977bce

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-03-11 15:46:14 UTC
FEDORA-2022-fa0fd2e5f0 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-fa0fd2e5f0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fa0fd2e5f0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-03-11 15:57:02 UTC
FEDORA-2022-9c42c03669 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-9c42c03669`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9c42c03669

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-03-11 15:57:54 UTC
FEDORA-EPEL-2022-a7681d7e28 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-a7681d7e28

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2022-03-11 19:26:20 UTC
FEDORA-2022-3f5d692439 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-3f5d692439`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3f5d692439

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-03-18 17:52:11 UTC
FEDORA-EPEL-2022-6e723fda27 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2022-03-18 18:01:26 UTC
FEDORA-EPEL-2022-1850977bce has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2022-03-18 19:13:16 UTC
FEDORA-2022-9c42c03669 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2022-03-18 20:06:15 UTC
FEDORA-2022-fa0fd2e5f0 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2022-03-18 20:24:48 UTC
FEDORA-EPEL-2022-a7681d7e28 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2022-03-26 15:19:21 UTC
FEDORA-2022-3f5d692439 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.