Bug 2064132 - Review Request: rust-bytes-cast-derive - Safely re-interpreting &[u8] bytes as custom structs without copying, for efficiently reading structured binary data
Summary: Review Request: rust-bytes-cast-derive - Safely re-interpreting &[u8] bytes a...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mads Kiilerich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2063941 2064133
TreeView+ depends on / blocked
 
Reported: 2022-03-15 06:59 UTC by Aleksei Bavshin
Modified: 2022-05-07 04:17 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-05-07 04:17:24 UTC
Type: ---
Embargoed:
mads: fedora-review+


Attachments (Terms of Use)

Description Aleksei Bavshin 2022-03-15 06:59:57 UTC
Spec URL: https://alebastr.fedorapeople.org/review/mercurial-rs/rust-bytes-cast-derive.spec
SRPM URL: https://alebastr.fedorapeople.org/review/mercurial-rs/rust-bytes-cast-derive-0.1.1-1.fc35.src.rpm
Description:
Safely re-interpreting &[u8] bytes as custom structs without copying, for
efficiently reading structured binary data. Procedural macro for compile-time
soundness checking.
Fedora Account System Username: alebastr

Comment 1 Mads Kiilerich 2022-03-15 14:20:36 UTC
I verified that the spec and source is exactly as generated with "rust2rpm -as bytes-cast-derive".

The "zlib or ASL 2.0 or MIT" license is OK.

The package builds locally on f35 x86_64, installs, and works for a local build of Mercurial with Rust extensions.

rpmlint is clean, except "W: no-documentation" and "E: summary-too-long". I don't think the 116 character summary will be a real problem, and certainly not worth deviating from upstream and making a first edit to the generated spec file.

Comment 2 Gwyn Ciesla 2022-04-04 21:19:20 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bytes-cast-derive

Comment 3 Fedora Update System 2022-04-05 17:27:51 UTC
FEDORA-2022-c7ededf903 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c7ededf903

Comment 4 Fedora Update System 2022-04-06 17:54:48 UTC
FEDORA-2022-c7ededf903 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-c7ededf903 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c7ededf903

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2022-05-07 04:17:24 UTC
FEDORA-2022-c7ededf903 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.