Bug 2064155 - Review Request: rust-vcsgraph - Library to perform various computation of a version control graph
Summary: Review Request: rust-vcsgraph - Library to perform various computation of a v...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mads Kiilerich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2063941
TreeView+ depends on / blocked
 
Reported: 2022-03-15 07:19 UTC by Aleksei Bavshin
Modified: 2022-05-07 04:17 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-07 04:17:49 UTC
Type: ---
Embargoed:
mads: fedora-review+


Attachments (Terms of Use)

Description Aleksei Bavshin 2022-03-15 07:19:40 UTC
Spec URL: https://alebastr.fedorapeople.org/review/mercurial-rs/rust-vcsgraph.spec
SRPM URL: https://alebastr.fedorapeople.org/review/mercurial-rs/rust-vcsgraph-0.2.0-1.fc35.src.rpm
Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rhg/monitor/
Description:
Library to perform various computation of a version control graph.
Fedora Account System Username: alebastr

Regarding `-a` flag - see https://pagure.io/fedora-rust/rust2rpm/issue/110

Comment 1 Mads Kiilerich 2022-03-15 14:25:05 UTC
I verified that the spec and source is exactly as generated with "rust2rpm -as vcsgraph", except

@@ -28,7 +28,6 @@
 %description -n %{crate} %{_description}
 
 %files       -n %{crate}
-# FIXME: no license files detected
 %doc README.md
 %{_bindir}/analytics
 %{_bindir}/testing
@@ -43,7 +42,6 @@
 use the "%{crate}" crate.
 
 %files          devel
-# FIXME: no license files detected
 %doc %{crate_instdir}/README.md
 %{crate_instdir}/
 
@@ -88,17 +86,17 @@
 %cargo_prep
 
 %generate_buildrequires
-%cargo_generate_buildrequires
+%cargo_generate_buildrequires -a
 
 %build
-%cargo_build
+%cargo_build -a
 
 %install
-%cargo_install
+%cargo_install -a
 
 %if %{with check}
 %check
-%cargo_test
+%cargo_test -a
 %endif
 
 %changelog

I think the -a explanation should be a comment in the spec so the deviation from rust2rpm is obvious. While https://pagure.io/fedora-rust/rust2rpm/issue/110 might be the core problem, it would be nice to have a hint what -a does and why it is a valid workaround. It seems like it is an argument for cargo-inspector, but it is not clear to me what it changes from what default.

The license file FIXME seems valid and points out an upstream problem - should it really just be removed like that?

The GPLv2+ license is OK.

The package builds locally on f35, installs, and works for enabling experimental build of Mercurial with Rust extensions.

rpmlint is clean, except "W: no-documentation".

Comment 2 Aleksei Bavshin 2022-03-16 04:58:55 UTC
Updated the spec with comments about both issues.

The upstream issue for missing license is https://foss.heptapod.net/mercurial/vcsgraph/-/issues/16

Comment 3 Gwyn Ciesla 2022-04-04 21:25:06 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-vcsgraph

Comment 4 Fedora Update System 2022-04-05 17:28:11 UTC
FEDORA-2022-c7ededf903 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c7ededf903

Comment 5 Fedora Update System 2022-04-06 17:55:04 UTC
FEDORA-2022-c7ededf903 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-c7ededf903 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c7ededf903

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2022-05-07 04:17:49 UTC
FEDORA-2022-c7ededf903 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.