Koji scratch build suceeded:
https://koji.fedoraproject.org/koji/taskinfo?taskID=88757079

> Changes from v2 to v3
> https://git.remirepo.net/cgit/rpms/php/sebastian/php-sebastian-type3.git/diff/php-sebastian-type3.spec?id=828cbb8bd0eb51ada46953cae96651e4906423ce

Diff is so simple but I will review this manually because I got some errors("Can't parse specfile: can't parse specfile) by using fedora-review in my environment. Please wait a moment.

Thanks in advance,
Hirotaka

Hi Remi, please see my review.

Issues:
* One rpmlint error. please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_rpmlint
```
# rpmlint php-sebastian-type3-3.0.0-1.fc37.noarch.rpm 
============================================================================================ rpmlint session starts ============================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

php-sebastian-type3.noarch: E: summary-too-long Collection of value objects that represent the types of the PHP type system, version 3
php-sebastian-type3.noarch: W: description-shorter-than-summary
============================================================= 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.0 s =============================================================

# rpmlint php-sebastian-type3-3.0.0-1.remi.src.rpm
============================================================================================ rpmlint session starts ============================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

php-sebastian-type3.src: E: unknown-key 1fef0014
php-sebastian-type3.src: E: summary-too-long Collection of value objects that represent the types of the PHP type system, version 3
php-sebastian-type3.src: W: strange-permission makesrc.sh 775
php-sebastian-type3.spec: W: invalid-url Source0: php-sebastian-type3-3.0.0-b233b84.tgz
php-sebastian-type3.src: W: description-shorter-than-summary
============================================================= 1 packages and 0 specfiles checked; 2 errors, 3 warnings, 2 badness; has taken 0.1 s =============================================================

```

* It's may not an issue but rpmbuild should stop building the package when `which` command fails because the test suite will not be executed.
```
%if %{with tests}

...(snip)...

: Run upstream test suite
ret=0
for cmd in php php74 php80 php81; do
  if which $cmd; then

...(snip)...

%else
: bootstrap build with test suite disabled
%endif
```

Memos to build the package manually:
```
% docker run -ti --privileged fedora-container-base-rawhide-20220626.n.0.x86_64 /bin/bash
# curl -o php-sebastian-type3.spec https://git.remirepo.net/cgit/rpms/php/sebastian/php-sebastian-type3.git/plain/php-sebastian-type3.spec?id=828cbb8bd0eb51ada46953cae96651e4906423ce
# curl -o php-sebastian-type3-3.0.0-1.remi.src.rpm https://rpms.remirepo.net/SRPMS/php-sebastian-type3-3.0.0-1.remi.src.rpm
# dnf update -y
# dnf install -y mock
# mock -r /etc/mock/fedora-rawhide-x86_64.cfg --clean
# mock -r /etc/mock/fedora-rawhide-x86_64.cfg --no-clean php-sebastian-type3-3.0.0-1.remi.src.rpm 
# mock -r /etc/mock/fedora-rawhide-x86_64.cfg --no-clean --copyout /builddir/build/RPMS/*.rpm .
# dnf install -y rpmlint
# rpmlint *.rpm
```

Thanks in advance,
Hirotaka

Thanks for your review.


Change:
https://git.remirepo.net/cgit/rpms/php/sebastian/php-sebastian-type3.git/commit/?id=25a094210011014afaa9bc6dd2828055cc4538f4

Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-sebastian-type3.git/plain/php-sebastian-type3.spec?id=25a094210011014afaa9bc6dd2828055cc4538f4
SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-type3-3.0.0-2.remi.src.rpm

> * It's may not an issue but rpmbuild should stop building the package when `which` command fails because the test suite will not be executed.

As fedora on have "php", the which is expected to NOT fail.

Hello Remi, Thanks for your reply. Package Approved. 

`E: unknown-key 1fef0014` means signature is unknown because the public key is not imported in the RPM database in my environment.

```
# rpmlint php-sebastian-type3-3.0.0-2.fc37.noarch.rpm
================================================================================== rpmlint session starts =================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

=================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s ==================================================


# rpmlint php-sebastian-type3-3.0.0-2.remi.src.rpm
================================================================================== rpmlint session starts =================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

php-sebastian-type3.src: E: unknown-key 1fef0014
php-sebastian-type3.src: W: strange-permission makesrc.sh 775
php-sebastian-type3.spec: W: invalid-url Source0: php-sebastian-type3-3.0.0-b233b84.tgz
=================================================== 1 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 0.1 s ==================================================
```

Regards,
Hirotaka

Thanks for the review!

SCL requests
https://pagure.io/releng/fedora-scm-requests/issue/45338
https://pagure.io/releng/fedora-scm-requests/issue/45339
https://pagure.io/releng/fedora-scm-requests/issue/45340

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-sebastian-type3

FEDORA-2022-40d47dd4e8 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-40d47dd4e8

FEDORA-2022-5d49aa2361 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5d49aa2361

FEDORA-2022-40d47dd4e8 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-40d47dd4e8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-40d47dd4e8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-5d49aa2361 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-5d49aa2361 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5d49aa2361

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-5d49aa2361 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-40d47dd4e8 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.