RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2064815 - sos raises exception when cleaning a substring from working dir
Summary: sos raises exception when cleaning a substring from working dir
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: sos
Version: 8.6
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Pavel Moravec
QA Contact: Miroslav Hradílek
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-16 15:54 UTC by Pavel Moravec
Modified: 2023-03-16 21:37 UTC (History)
8 users (show)

Fixed In Version: sos-4.5.0-1.el8.noarch
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-03-16 21:36:57 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github sosreport sos pull 2887 0 None open Sos pmoravec dont obfuscate tmpdir path 2022-03-16 17:01:22 UTC
Github sosreport sos pull 3065 0 None open [report] Prevent obfuscating tmpDir path before tarbal move 2022-11-13 16:00:59 UTC
Github sosreport sos pull 3136 0 None open [tests] Add test for #3071 2023-02-15 08:44:06 UTC
Red Hat Issue Tracker RHELPLAN-115768 0 None None None 2022-03-16 17:05:32 UTC

Description Pavel Moravec 2022-03-16 15:54:36 UTC
Description of problem:
Artificial but very evident reproducer:

sos report --clean --keywords tmp -o system --batch

fails with:

[cleaner] Obfuscating ui.log
[cleaner] Obfuscating manifest.json
Creating compressed archive...

 No such file or directory while finalizing archive /var/tmp/sos.0twrlqpo/sosreport-pmoravec-rhel8-2022-03-16-bbwngfg

Creating archive tarball failed.
Traceback (most recent call last):
  File "bin/sos", line 22, in <module>
    sos.execute()
  File "/root/sos-main/sos/__init__.py", line 188, in execute
    self._component.execute()
  File "/root/sos-main/sos/report/__init__.py", line 1600, in execute
    return self.final_work()
  File "/root/sos-main/sos/report/__init__.py", line 1497, in final_work
    archivestat, map_file=map_file)
UnboundLocalError: local variable 'archivestat' referenced before assignment

The reason is that an attempt to rename the directory (https://github.com/sosreport/sos/blob/main/sos/archive.py#L554) attempts to rename also *path* to it:

[cleaner] Could not write private map file: [Errno 2] No such file or directory: '/var/obfuscatedword3/host10report-host0-2022-03-16-guuqlpu-private_map'
[cleaner] Wrote mapping to /etc/sos/cleaner/default_mapping
[cleaner] Obfuscating sos.log
[cleaner] Obfuscating ui.log
[cleaner] Obfuscating manifest.json
Creating compressed archive...
---->> os.rename(/var/tmp/sos.ifuhcmbt/sosreport-pmoravec-rhel8-2022-03-16-guuqlpu, /var/obfuscatedword3/host10.ifuhcmbt/host10report-host0-2022-03-16-guuqlpu)

this fails.

Anyway, we have to fix also the "Could not write private map file" issue on the same topic.


Version-Release number of selected component (if applicable):
sos-4.2-15


How reproducible:
100%


Steps to Reproduce:
1. sos report --clean --keywords tmp -o system --batch


Actual results:
Above backtrace and no private map file (on 2nd run).


Expected results:
No backtrace, private map file created.


Additional info:

Comment 1 Pavel Moravec 2022-06-14 06:49:45 UTC
This will land in RHEL in sos-4.4 in 8.8/9.2 automatically, due to the rebase BZ.

Comment 6 Pavel Moravec 2022-11-11 12:48:41 UTC
IMHO too low prio to respin 8.8 due to this - rescheduling it to 8.9 then when we should properly fix it.

Comment 7 Pavel Moravec 2022-11-13 16:01:00 UTC
.. and upstream https://github.com/sosreport/sos/pull/3065 raised.

Comment 9 Pavel Moravec 2023-02-15 08:44:07 UTC
Adding avocado test.

Comment 11 Pavel Moravec 2023-03-16 21:36:57 UTC
Closing the bugzilla as the fix has been delivered in sos-4.5.0-1.el8 released via https://access.redhat.com/errata/RHBA-2023:1300 errata.


Note You need to log in before you can comment on or make changes to this bug.