Bug 2065451 - Review Request: rust-serde_qs - Querystrings for Serde
Summary: Review Request: rust-serde_qs - Querystrings for Serde
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-17 20:38 UTC by Jan Baudisch
Modified: 2022-05-19 01:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-09 16:12:58 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Fabio Valentini 2022-04-30 10:01:02 UTC
Are you still interested in packaging this crate?
If yes, please refresh the packaging with rust2rpm 21.

Comment 2 Jan Baudisch 2022-05-03 09:19:34 UTC
Refreshed with rust2rpm 21.

Comment 3 Fabio Valentini 2022-05-04 09:57:56 UTC
Several feature subpackages are not installable due to broken dependencies:

- actix-web2: only actix-web 3 is packaged for Fedora right now
- actix-web4: only actix-web 3 is packaged for Fedora right now
- axum-framework: axum is not packaged for Fedora yet

Assuming you don't need serde_qs support for any of those web frameworks, just disable the feature subpackages.
This can be achieved in three different ways:

1) patch Cargo.toml to remove the features (and optional dependencies) you don't need / want
2) manually remove the broken feature subpackages you don't need / want
3) create a .rust2rpm.conf config file to specify which feature subpackages should not be generated (this basically automates option 2):

[DEFAULT]
unwanted-features =
  actix-web2
  actix-web4
  axum

If you place this file into the directory where you run rust2rpm, it will use the settings from it during .spec generation.
I would recommend this option, since you can also commit this .rust2rpm.conf file into dist-git to preserve these settings for future updates.

Comment 4 Jan Baudisch 2022-05-08 09:39:51 UTC
Thank you for pointing this out. I updated the package with the rust2rpm config file.
On a side note: How can I check for broken dependencies?

Comment 5 Fabio Valentini 2022-05-08 12:20:52 UTC
You can either:

1) run a local mock build as usual and then use "mock -r whatever-buildroot-you-used install ./path-to-built-rpms/*.noarch.rpm"
2) run your local mock build with "--postinstall", which will print installation errors after the build finishes

And given that the "actix2", "actix4", and "axum-framework" features depend on those that you already disabled, you'll need to drop them, as well.
Executing a mockbuild and installing the results (either manually or by using --postinstall) should succeed without installability errors.

Comment 6 Jan Baudisch 2022-05-08 13:00:27 UTC
Ok, thank you for explaining.
I removed the actix{1,2} features and all the subpackages install now.

Comment 7 Fabio Valentini 2022-05-08 14:50:23 UTC
Looks good to me now, thanks.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 8 Gwyn Ciesla 2022-05-09 13:55:28 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serde_qs

Comment 9 Fedora Update System 2022-05-09 16:12:05 UTC
FEDORA-2022-5e53455c58 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5e53455c58

Comment 10 Fedora Update System 2022-05-09 16:12:58 UTC
FEDORA-2022-5e53455c58 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-05-10 04:42:57 UTC
FEDORA-2022-d890594d59 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d890594d59

Comment 12 Fedora Update System 2022-05-10 05:02:03 UTC
FEDORA-2022-fd328e7548 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd328e7548

Comment 13 Fedora Update System 2022-05-11 02:37:31 UTC
FEDORA-2022-d890594d59 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-d890594d59 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d890594d59

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-05-11 02:45:05 UTC
FEDORA-2022-fd328e7548 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-fd328e7548 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd328e7548

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-05-19 01:16:43 UTC
FEDORA-2022-d890594d59 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-05-19 01:22:18 UTC
FEDORA-2022-fd328e7548 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.