RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2065706 - Removal of invalid vendored project with unwanted license in aardvark-dns/netavark
Summary: Removal of invalid vendored project with unwanted license in aardvark-dns/net...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: containers-common
Version: 9.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: rc
: ---
Assignee: Jindrich Novy
QA Contact: Joy Pu
URL:
Whiteboard:
Depends On:
Blocks: 2065707 2067486
TreeView+ depends on / blocked
 
Reported: 2022-03-18 14:26 UTC by Jindrich Novy
Modified: 2023-09-15 02:00 UTC (History)
5 users (show)

Fixed In Version: containers-common-1-34.el9_0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2065707 2067486 (view as bug list)
Environment:
Last Closed: 2022-05-17 12:35:38 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-116124 0 None None None 2022-03-18 14:34:13 UTC
Red Hat Product Errata RHBA-2022:2354 0 None None None 2022-05-17 12:35:54 UTC

Description Jindrich Novy 2022-03-18 14:26:07 UTC 
The vendoring of libgit2-sys in the containers/youki project appears to be dragging in the vendor/libgit2-sys/libgit2/src/streams/openssl_dynamic.h (https://github.com/containers/youki/blob/main/crates/Cargo.lock#L1005) that is causing some potential licensing issues. Youki is a container runtime like runc and crun, and I was unaware that we were shipping it on RHEL at this time.

From legal:

Regarding the openssl-nokia license, that license was provisionally[1]
approved for openssl code:

   Red Hat prefers to avoid redistributing code where patent rights are
   explicitly being withheld, which is the case here. This legal text
   has been part of OpenSSL for a long time, and It can continue to be
   redistributed as part of OpenSSL. If this license type occurs in
   non-OpenSSL code, please contact oslc for review of the
   situation.

It appears that this other project has "borrowed" an openssl file with
this very old license in it.

If there were an option to remove it...if it were only a
convenience...then it might be worth trying to eliminate it.

https://pelc.engineering.redhat.com/licenses/1777/
Comment 2 Tom Sweeney 2022-03-21 20:33:18 UTC 
Fixed with https://github.com/containers/aardvark-dns/pull/106
Comment 3 Tom Sweeney 2022-03-21 20:36:45 UTC 
@ddarrah @ypu could we get a qa_ack on this please?
Comment 4 Tom Sweeney 2022-03-21 21:02:47 UTC 
======= Impact Statement ======= 

What is the benefit of making this change after the deadline? What is the impact on customer satisfaction, and on the business?

a. For bugfixes, there must be support from someone in Customer Support, a Partner Manager, Product Manager, and/or a Business Unit rep. (e.g., potentially from a layered product BU). 
b. It is unusual for new features to be allowed in the release after the deadline. For this reason, additional justification must be obtained from a stakeholder outside of the SST, to ensure an objective review of the benefit to the product. 

What is the risk to the release schedule, quality, and the impact of diverting resources from other efforts? Will there be enough time to do the necessary large-scale, cross-function, regression, stress, or fault-insertion testing that may be required to verify this change? 

This issue was discovered in a late PELC review.   There's a gnu-license for SSL that's old and that the licensing folks have asked us to remove if at all possible.  It is being pulled into the aardvark-dns project via the usage of the Rust libgit2-sys library.  There were only a few calls made to this library in aardvark-dns.  By removing the library and making a few small tweaks, which was already completed in Upstream a few weeks ago, the problematic license is no longer included in aardvark-dns.  The aardvarkk-dns project is a relatively new project that's used to handle DNS functionality within Podman.

There is little risk to the change, and it would be only for Podman as no other projects use aardvark-dns.  The fix is ready to go, we just need the green light.
Comment 6 Tom Sweeney 2022-03-24 14:44:18 UTC 
PR complete.  Setting to Post an assigning to @jnovy for further BZ and packaging needs.

PR: https://github.com/containers/aardvark-dns/pull/106
Comment 7 Tom Sweeney 2022-03-24 16:06:48 UTC 
And I left of the second PR that is part of this fix: https://github.com/containers/netavark/pull/262
Comment 8 Jindrich Novy 2022-03-28 12:25:52 UTC 
New PELC review in progress: https://pelc.engineering.redhat.com/tasks/509312/
Comment 13 Jindrich Novy 2022-04-01 05:31:55 UTC 
Looking good: https://pelc.engineering.redhat.com/adhoc/reviews/20742/#license
Comment 14 Joy Pu 2022-04-01 08:03:46 UTC 
Checked with containers-common-1-34.el9_0.src.rpm and the file is already removed. So move it to verified. Details:
# find . -name "openssl_dynamic.h"
# ls
containers-aardvark-dns-0a8eabf  containers-netavark-93af394
Comment 16 errata-xmlrpc 2022-05-17 12:35:38 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: containers-common), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2354
Comment 17 Red Hat Bugzilla 2023-09-15 01:52:58 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 365 days
Note You need to log in before you can comment on or make changes to this bug.