Bug 2066854 - Syntax error in orchestration plugin settings crashes horizon
Summary: Syntax error in orchestration plugin settings crashes horizon
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: puppet-horizon
Version: 17.0 (Wallaby)
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ga
: 17.0
Assignee: Radomir Dopieralski
QA Contact: Ronnie Rasouli
URL:
Whiteboard:
Depends On:
Blocks: 2067112 2067114
TreeView+ depends on / blocked
 
Reported: 2022-03-22 15:55 UTC by Radomir Dopieralski
Modified: 2025-01-17 19:00 UTC (History)
7 users (show)

Fixed In Version: puppet-horizon-18.5.1-0.20220428001500.6fc4f4d.el9ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2067112 (view as bug list)
Environment:
Last Closed: 2022-09-21 12:19:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1965970 0 None None None 2022-03-22 16:51:38 UTC
OpenStack gerrit 834745 0 None master: MERGED puppet-horizon: Fix syntax error in individual dashboard settings (Ie866b35306cadb5e7dad53b0c05c84023c134c3b) 2022-07-12 14:22:20 UTC
Red Hat Issue Tracker OSP-14163 0 None None None 2022-03-22 16:07:46 UTC
Red Hat Product Errata RHEA-2022:6543 0 None None None 2022-09-21 12:20:14 UTC

Description Radomir Dopieralski 2022-03-22 15:55:49 UTC
The settings file for heat-ui contains a syntax error which prevents Horizon from starting up properly.

Can not exec settings snippet _1699_orchestration_settings.py
Traceback (most recent call last):
  File "/usr/share/openstack-dashboard/openstack_dashboard/settings.py", line 272, in <module>
    exec(f.read())
  File "<string>", line 29
    'level': 'INFO',
          ^
SyntaxError: invalid syntax

Comment 3 Takashi Kajinami 2022-03-22 16:50:46 UTC
The issue was introduced by puppet-horizon changes which were backported to solve bz 1938217 .

The same issue exists in the three dashboard plugins(heat-ui, manila-ui and octavia-ui).

Comment 4 Takashi Kajinami 2022-03-22 17:13:17 UTC
(In reply to Takashi Kajinami from comment #3)
> The issue was introduced by puppet-horizon changes which were backported to
> solve bz 1938217 .
> 
> The same issue exists in the three dashboard plugins(heat-ui, manila-ui and
> octavia-ui).

The issue with horizon-dashboard was somehow fixed between stable/victoria and stable/ussuri,
so the issue does not affect RHOSP16.2.

However the syntax error in octavia-dashboard and manila-dashboard is present in stable/train,
which makes RHOSP16.2 affected by the issue when Manila or Octavia is enabled...

Comment 5 Takashi Kajinami 2022-03-23 11:27:24 UTC
(In reply to Takashi Kajinami from comment #4)
> (In reply to Takashi Kajinami from comment #3)
> ...
> 
> However the syntax error in octavia-dashboard and manila-dashboard is
> present in stable/train,
> which makes RHOSP16.2 affected by the issue when Manila or Octavia is
> enabled...

Fortunately the patches[1] to enable these implementations are not included in
upcoming RHOSP16.2.2, so RHOSP16.2 is not yet affected.
So what we need is to ensure the fix for puppet-horizon is included in RHOSP16.2.3.

Comment 6 Takashi Kajinami 2022-03-23 11:28:30 UTC
Reposting to fix the missing link [1]

 [1] https://review.opendev.org/q/topic:puppet-horizon-dashboards-stable%252Ftrain

Comment 7 Yaniv Kaul 2022-06-20 12:52:54 UTC
https://review.opendev.org/c/openstack/puppet-horizon/+/834745/ is merged, what's the next step here?

Comment 8 Radomir Dopieralski 2022-06-27 12:12:37 UTC
@ykaul I can see the patch is imported to our rhos-17.0-trunk-patches, so there is nothing left for us to do — it will be included in the next build.

Comment 10 Yaniv Kaul 2022-07-27 07:29:52 UTC
(In reply to Radomir Dopieralski from comment #8)
> @ykaul I can see the patch is imported to our
> rhos-17.0-trunk-patches, so there is nothing left for us to do — it will be
> included in the next build.

Need to make sure they do get in (comment #8 is a month old) and delivered to QE.

Comment 11 Radomir Dopieralski 2022-07-28 12:53:57 UTC
It's included in RHOS-17.0-RHEL-8-20220520.n.1 according to LADA.

Comment 21 errata-xmlrpc 2022-09-21 12:19:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 17.0 (Wallaby)), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:6543

Comment 22 Edward357Johnson 2025-01-03 09:20:17 UTC Comment hidden (spam)

Note You need to log in before you can comment on or make changes to this bug.