Bug 2068115 - resource tab extension fails to show up
Summary: resource tab extension fails to show up
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.10
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.11.0
Assignee: Andrew Ballantyne
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks: 2069246
TreeView+ depends on / blocked
 
Reported: 2022-03-24 13:53 UTC by cvogt
Modified: 2022-08-10 11:02 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
: 2069246 (view as bug list)
Environment:
Last Closed: 2022-08-10 11:01:08 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 11228 0 None open Bug 2068115: Fixed the rendering of a Tab Extension when there is a version present 2022-03-24 21:58:17 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 11:02:25 UTC

Description cvogt 2022-03-24 13:53:44 UTC
Description of problem:
The resource tab extension ('console.page/resource/tab') fails to show up when the model match includes a `version` along with the `group` and `kind`.

The problem is a result of using the wrong function to convert the model to a reference string for comparison:
https://github.com/openshift/console/blob/905c162730c05eb008ee39e49b91da86dc97f9b7/frontend/public/components/factory/details.tsx#L95

`referenceFor` is used instead of `referenceForModel`

Additionally it looks like the extension definition is incorrect as `href` is marked optional but it should be required or a path be required. 


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. create a `console.page/resource/tab` extension
2. set the model to have version=v1, group=project.openshift.io, kind=project
3. load the plugin in console
4. navigate to a project details page

Actual results:
Extension tab does not show up.


Expected results:
Extension tab should show up.

Additional info:

Comment 3 Yadan Pei 2022-04-14 02:59:21 UTC
1. with console.page/resource/tab extensions added in https://github.com/openshift/console/blob/master/dynamic-demo-plugin/console-extensions.json#L189%EF%BD%9EL201
2. load plugin
3. navigate to project details page, we can see 'Demo Plugin' tab showing up

verified on 4.11.0-0.nightly-2022-04-12-072444

Comment 4 Yadan Pei 2022-04-14 03:00:04 UTC
I tested the fix by applying oc-manifest.yaml with image quay.io/yapei/console-demo-plugin:411

Comment 6 errata-xmlrpc 2022-08-10 11:01:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069


Note You need to log in before you can comment on or make changes to this bug.